Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql products query returns only ids for dropdows or multiselect fields #28200

Closed
maximilianmikus opened this issue May 12, 2020 · 31 comments · May be fixed by #31622
Closed

Graphql products query returns only ids for dropdows or multiselect fields #28200

maximilianmikus opened this issue May 12, 2020 · 31 comments · May be fixed by #31622
Assignees
Labels
Area: APIs Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed PAP Partners acceleration program Partner: Atwix Pull Request is created by partner Atwix Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@maximilianmikus
Copy link

maximilianmikus commented May 12, 2020

Preconditions (*)

  1. 2.3.5-p1 with sample data

Steps to reproduce (*)

  1. u can use this magento instance (https://magento2.kask.at/graphql) or your own testing instance with sample data. query /graphql for a product that has the gender attribute (multiselect) e.g. "dual-handle-cardio-ball"
query productDetail($url_key: String) {
  productDetail: products(filter: {url_key: {eq: $url_key}}) {
    items {
      name
      url_key
      gender
    }
  }
}

variables:

{
  "url_key": "dual-handle-cardio-ball"
}

Expected result (*)

I would expext the result to contain the labels

{
  "data": {
    "productDetail": {
      "items": [
        {
          "name": "Dual Handle Cardio Ball",
          "url_key": "dual-handle-cardio-ball",
          "gender": ["Men","Women","Unisex"]
        }
      ]
    }
  }
}

Actual result (*)

the response only returns the value ids.

{
  "data": {
    "productDetail": {
      "items": [
        {
          "name": "Dual Handle Cardio Ball",
          "url_key": "dual-handle-cardio-ball",
          "gender": "5507,5508,5511"
        }
      ]
    }
  }
}
@m2-assistant
Copy link

m2-assistant bot commented May 12, 2020

Hi @maximilianmikus. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@maximilianmikus do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 12, 2020
@maximilianmikus
Copy link
Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Magento instance deployment temporary unavailable due to service maintenance.

@maximilianmikus
Copy link
Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Magento instance deployment temporary unavailable due to service maintenance.

@maximilianmikus
Copy link
Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Magento instance deployment temporary unavailable due to service maintenance.

@maximilianmikus
Copy link
Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @maximilianmikus. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @maximilianmikus, here is your Magento instance.
Admin access: https://i-28200-2-4-develop.instances.magento-community.engineering/admin_b3e5
Login: cf115cc0 Password: 32c908c14326
Instance will be terminated in up to 3 hours.

@maximilianmikus
Copy link
Author

I can confirm this happens on 2.4-develop

the query:

query productDetail($url_key: String) {
  productDetail: products(filter: {url_key: {eq: $url_key}}) {
    items {
      name
      url_key
      mycolor
      mysize
    }
  }
}

with variables

{
  "url_key": "simple-product-28"
}

yields

{
  "data": {
    "productDetail": {
      "items": [
        {
          "name": "Simple Product 28",
          "url_key": "simple-product-28",
          "mycolor": 6,
          "mysize": 9
        }
      ]
    }
  }
}

It should actually contain the labels. "my yellow" and "my large"

@m2-assistant
Copy link

m2-assistant bot commented Jun 11, 2020

Hi @paliarush. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@m2-assistant
Copy link

m2-assistant bot commented Jun 11, 2020

Hi @danielrenaud. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

shikhamis11 added a commit to shikhamis11/magento2 that referenced this issue Nov 10, 2021
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 22, 2021
@cpartica cpartica added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. and removed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. labels Apr 8, 2022
@cpartica cpartica removed this from the 2.4.3 milestone Apr 8, 2022
@cpartica cpartica added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: APIs Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 8, 2022
@github-jira-sync-bot
Copy link

github-jira-sync-bot commented Apr 8, 2022

✅ Jira issue https://jira.corp.magento.com/browse/AC-2796 is successfully created for this GitHub issue.

https://jira.corp.adobe.com/browse/AC-2796

@m2-assistant
Copy link

m2-assistant bot commented Apr 8, 2022

✅ Confirmed by @cpartica. Thank you for verifying the issue.
Issue Available: @cpartica, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@marwan-corals
Copy link

hello, any idea on this issue and when its expected to be fixed ?

@engcom-Charlie
Copy link
Contributor

@cpartica, as you mentioned in JIRA comment, that we need an approved schema for this one, and alignment with the pwa metapackage schema. This will take time and moving it to 2.4.6.

Hence moving the associated PR to on Hold, until the further updates on JIRA.

@harrywutech
Copy link

Hi there, is there a patch or solusion for this now? Thanks

@GamesmenJordan
Copy link

Over 2 years and counting and still no good support for two entire fundamental attribute data types and the can continues to be kicked down the road.

@github-jira-sync-bot github-jira-sync-bot added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Oct 17, 2022
@engcom-Charlie
Copy link
Contributor

As mentioned in above #28200 (comment), we are doing follow up with team. We are waiting for the PO's input on the same. Once will get the clarity on that, we will proceed further on this.

Thank you!

@m2-assistant
Copy link

m2-assistant bot commented Jul 20, 2023

Hi @chernenm. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: APIs Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed PAP Partners acceleration program Partner: Atwix Pull Request is created by partner Atwix Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects