Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

price-box.js triggers priceUpdated and reloadPrice events for every configurable product before clicking on a selection #39543

Closed
1 of 5 tasks
cptX opened this issue Jan 14, 2025 · 5 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p3 Indicates original Magento version for the Issue report.

Comments

@cptX
Copy link

cptX commented Jan 14, 2025

Preconditions and environment

  • Magento version 2.4.7-p3

vendor/magento/module-catalog/view/base/web/js/price-box.js triggers priceUpdated and reloadPrice events for every configurable product on every page (product page, catalog page, carousels etc) before clicking on any selection. For example you visit a catalog page with 12 configurable products, these events will be triggered for all 12 products during page load before even clicking on one of them.

This of course introduces a huge overload on the CPU, a delay on page finalizing and a bad experience and ranking...
Why is this happening? I have studied a bit the code and I think the whole code point is to refresh the product price field in case the user selects an option on the configuration product. Why should we have price refreshes before even clicking on any option?

Steps to reproduce

Go to file vendor/magento/module-catalog/view/base/web/js/price-box.js and add the line
console.log(test); or alert(test);

after the line

reloadPrice: function reDrawPrices() {

Then, try to load a page that includes configurable products.
You will see how many times the function will be called before even clicking on any option of a configurable product.

Expected result

priceUpdated and reloadPrice events should be triggered only when an option on a configurable product is selected.

Actual result

priceUpdated and reloadPrice events are now triggered in advance in every page load for every configurable product that is included in the page.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Jan 14, 2025

Hi @cptX. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p3 Indicates original Magento version for the Issue report. label Jan 16, 2025
@engcom-Bravo engcom-Bravo self-assigned this Jan 16, 2025
Copy link

m2-assistant bot commented Jan 16, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hi @cptX,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the attached video.

Screen.Recording.2025-01-30.at.11.34.27.am.mov

priceUpdated and reloadPrice events is triggered only when an option on a configurable product is selected.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Jan 30, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Jan 30, 2025
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Jan 30, 2025
@engcom-Bravo
Copy link
Contributor

Hi @cptX,

This issue is being closed since it has not been updated in a long time.Please feel free to reopen or raise a new ticket if the issue still exists.

Thanks.

@cptX
Copy link
Author

cptX commented Feb 10, 2025

Hi @engcom-Bravo I don't understand the point of your video! The meaning is to check the console log for how many times "test" is logged just by loading the page, not by clicking on options, but in your video you don't show the console logs and also you click on options. It is like you didn't understand the problem at all. Please read my description again and repeat the test. You will see that the console.log is called many times on every reload before clicking on options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p3 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

2 participants