Skip to content

Display tax percent in current locale number format #18724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-ifrim opened this issue Oct 21, 2018 · 24 comments · May be fixed by #39795
Open

Display tax percent in current locale number format #18724

daniel-ifrim opened this issue Oct 21, 2018 · 24 comments · May be fixed by #39795
Assignees
Labels
Area: Tax Component: Locale Event: squashtoberfest Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@daniel-ifrim
Copy link

daniel-ifrim commented Oct 21, 2018

Preconditions (*)

  1. Magento 2.4-develop
  2. Set locale to Germany or other European country where decimal character is comma
  3. In Admin > Stores > Configuration > Sales > Tax > Shopping Cart Display Settings > Display Full Tax Summary = Yes and in the other section "Orders, Invoices, Credit Memos Display Settings"
  4. Set a tax percent in admin with decimals like 50.1.

Steps to reproduce (*)

  1. Add in cart a product.
  2. Go to cart page
  3. Go to checkout and look at the summary block
  4. Place the order and see it in My Account
  5. See the order in admin
  6. See emails sent about order

Expected result (*)

  1. It should display "50,1" percent with comma.

Actual result (*)

  1. In cart estimation and in other places displays "50.1" percent
  2. The same number format in other places
    In email
    image
    In summary block
    image
@magento-engcom-team
Copy link
Contributor

Hi @daniel-ifrim. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@daniel-ifrim do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 21, 2018
@daniel-ifrim
Copy link
Author

@magento-engcom-team give me 2.3

@daniel-ifrim
Copy link
Author

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @daniel-ifrim. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @daniel-ifrim, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18724-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@daniel-ifrim
Copy link
Author

@magento-engcom-team I managed to add to cart on the instance given by adding the product to comparison list and than add to cart. Otherwise it says Session has expired or something.

@Shubham0492
Copy link

#SQUASHTOBERFEST

Shubham0492 pushed a commit to Shubham0492/magento2 that referenced this issue Oct 26, 2018
@Shubham0492 Shubham0492 self-assigned this Oct 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Shubham-Webkul. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@Shubham0492
Copy link

magento-engcom-team give me 2.2-develop instance

Shubham0492 pushed a commit to Shubham0492/magento2 that referenced this issue Nov 12, 2018
@shikhamis11 shikhamis11 added Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Dec 22, 2018
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 22, 2018
@magento-engcom-team
Copy link
Contributor

@shikhamis11 Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97301 were created

@shikhamis11 shikhamis11 added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Dec 22, 2018
@engcom-Delta engcom-Delta added Component: Tax Component: Locale Area: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Component: Tax Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels May 29, 2024
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 29, 2024
@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Locale Area: Tax and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Locale Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Tax labels May 29, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12038 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented May 29, 2024

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-12038

@Sathakathulla-S
Copy link

@magento I'm working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tax Component: Locale Event: squashtoberfest Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
10 participants