From 531c3734e9bbdf7443f334ea8e2a00f2e9feff71 Mon Sep 17 00:00:00 2001 From: Senthilkumar Muppidathi Date: Fri, 6 Jun 2025 15:34:35 +0700 Subject: [PATCH 1/2] Fixed Salesrule Subselect only with Qty condition and matching !getConditions --- .../SalesRule/Model/Rule/Condition/Product/Subselect.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/SalesRule/Model/Rule/Condition/Product/Subselect.php b/app/code/Magento/SalesRule/Model/Rule/Condition/Product/Subselect.php index 1591287110e5..68591c309023 100644 --- a/app/code/Magento/SalesRule/Model/Rule/Condition/Product/Subselect.php +++ b/app/code/Magento/SalesRule/Model/Rule/Condition/Product/Subselect.php @@ -157,7 +157,7 @@ public function validate(AbstractModel $model) { $subSelectConditionsFlag = true; if (!$this->getConditions()) { - return false; + return true; } $attr = $this->getAttribute(); $total = 0; From 39ddc9c08eea6832e618ea7b4265a73fb5e132e5 Mon Sep 17 00:00:00 2001 From: Senthilkumar Muppidathi Date: Fri, 6 Jun 2025 16:55:05 +0700 Subject: [PATCH 2/2] Unit test was also incorrectly written and fixed UT aligning to the fix --- .../Test/Unit/Model/Rule/Condition/Product/SubselectTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/SalesRule/Test/Unit/Model/Rule/Condition/Product/SubselectTest.php b/app/code/Magento/SalesRule/Test/Unit/Model/Rule/Condition/Product/SubselectTest.php index ba2e530a9dc0..2c6727aa9b6e 100644 --- a/app/code/Magento/SalesRule/Test/Unit/Model/Rule/Condition/Product/SubselectTest.php +++ b/app/code/Magento/SalesRule/Test/Unit/Model/Rule/Condition/Product/SubselectTest.php @@ -259,7 +259,7 @@ public static function dataProviderForFixedBundleProduct(): array 'valueParsed' => 100 ], false, - false + true ], 'validate true for bundle product data with conditions for attribute base_row_total w/o multi shipping' =>