Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Commit 3d1a833

Browse files
committed
Fix .gitignore, update README
1 parent 895ff42 commit 3d1a833

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,4 +125,4 @@ coverage
125125
*-deploy-package*.zip
126126

127127
# This should go only into the deploy package, not repo
128-
lib/*.so
128+
lib/*.so*

README.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
## Requirements
66

77
- Using AWS CloudFront as a CDN server.
8-
- Docker and node@8.10.0 for development.
8+
- Docker and node@10.x for development.
99

1010
## Setting up
1111

@@ -25,6 +25,12 @@ Or enter the command directly:
2525
docker run --rm --tty --volume "$(pwd):/var/app" mageops/aws-lambda-build:nodejs10.x nodejs-yarn edge-lambda-deploy-package
2626
```
2727

28+
**NOTE:** _Even though lambda's runtime should be based on Amazon Linux 2 which has `libjpeg-turbo`
29+
included by default, this library seems to be missing. The custom build hook installs appropriate
30+
so files into the `lib/` subdirectory. It's possible that Lambda@Edge still uses
31+
Amazon Linux 1 as the system runtime, what is not surprising given that this specific lambda
32+
type does not support node12.x in contrast to "standard ones"._
33+
2834
#### Docker image for building lambdas
2935

3036
The package is built using [mageops/aws-lambda-build](https://hub.docker.com/r/mageops/aws-lambda-build).
@@ -36,7 +42,7 @@ Go to [Lambda Management Console](https://console.aws.amazon.com/lambda/home?reg
3642

3743
**Name:** `originRequest`
3844

39-
**Runtime:** `Node.js 12.x`
45+
**Runtime:** `Node.js 10.x`
4046

4147
**Role:** `Create new role from template(s)`
4248

0 commit comments

Comments
 (0)