♻️ Enforcing authority signature check on systems

Author: notdanilo

crates/bolt-lang/attribute/src/common/mod.rs

@@ -22,8 +22,7 @@ pub fn inject_program(module: &mut syn::ItemMod) {
             syn::Item::Struct(syn::parse_quote! {
                 #[derive(Accounts)]
                 pub struct VariadicBoltComponents<'info> {
-                    #[account()]
-                    pub authority: AccountInfo<'info>,
+                    pub authority: Signer<'info>,
                 }
             }),
         );

crates/bolt-lang/attribute/src/system/mod.rs

@@ -50,8 +50,7 @@ pub fn process(_attr: TokenStream, item: TokenStream) -> TokenStream {
                 let variadic_struct: Item = parse_quote! {
                     #[derive(Accounts)]
                     pub struct VariadicBoltComponents<'info> {
-                        #[account()]
-                        pub authority: AccountInfo<'info>,
+                        pub authority: Signer<'info>,
                     }
                 };
                 items.insert(1, variadic_struct);

crates/bolt-lang/attribute/system-input/src/lib.rs

@@ -76,9 +76,7 @@ pub fn system_input(_attr: TokenStream, item: TokenStream) -> TokenStream {
         #[derive(Accounts)]
         pub struct #name<'info> {
             #(#transformed_fields)*
-            /// CHECK: Authority check
-            #[account()]
-            pub authority: AccountInfo<'info>,
+            pub authority: Signer<'info>,
         }
     };
 

crates/programs/world/src/lib.rs

@@ -558,7 +558,13 @@ fn system_execute<'info>(
     use anchor_lang::solana_program::instruction::{AccountMeta, Instruction};
     use anchor_lang::solana_program::program::invoke;
 
-    let mut accounts = vec![AccountMeta::new_readonly(authority.key(), false)];
+    let mut accounts = vec![
+        AccountMeta {
+            pubkey: authority.key(),
+            is_signer: authority.is_signer,
+            is_writable: authority.is_writable,
+        }
+    ];
     accounts.extend(remaining_accounts.iter().map(|account| {
         AccountMeta {
             pubkey: account.key(),

docs/REPORT.md

@@ -4,6 +4,6 @@ xychart
     title "Bolt Apply System Cost"
     x-axis ["1C-CPIs:2","2C-CPIs:3","3C-CPIs:4","4C-CPIs:5","5C-CPIs:6","6C-CPIs:7","7C-CPIs:8","8C-CPIs:9","9C-CPIs:10","10C-CPIs:11"]
     y-axis "CU" 5000 --> 200000
-    bar [14633,23134,31660,40212,48956,57569,66228,75107,83986,92730]
-    bar [6065,11042,16014,20986,25958,30934,35929,41116,46111,51107]
+    bar [14428,22876,31384,39897,48603,57176,65796,74635,83475,92178]
+    bar [5940,10903,15896,20868,25841,30816,35811,40997,45992,50986]
 ```