Skip to content

Commit b250004

Browse files
committed
fix(committor): propagate tx assembly errors in prepare_for_strategy
Replace .expect() with ? so assembly failures return an error instead of panicking the committor worker. Fixes #1018
1 parent 3838992 commit b250004

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

  • magicblock-committor-service/src/transaction_preparator

magicblock-committor-service/src/transaction_preparator/mod.rs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,16 +101,14 @@ impl TransactionPreparator for TransactionPreparatorImpl {
101101
.await?;
102102
metrics::observe_committor_intent_alt_count(lookup_tables.len());
103103

104-
let message =
105-
TransactionUtils::assemble_tasks_tx_with_uniqueness_nonce(
106-
authority,
107-
&tx_strategy.optimized_tasks,
108-
self.compute_budget_config.compute_unit_price,
109-
&lookup_tables,
110-
tx_strategy.uniqueness_nonce,
111-
)
112-
.expect("Possibility to assemble checked above")
113-
.message;
104+
let message = TransactionUtils::assemble_tasks_tx_with_uniqueness_nonce(
105+
authority,
106+
&tx_strategy.optimized_tasks,
107+
self.compute_budget_config.compute_unit_price,
108+
&lookup_tables,
109+
tx_strategy.uniqueness_nonce,
110+
)?
111+
.message;
114112

115113
Ok(message)
116114
}

0 commit comments

Comments
 (0)