Skip to content

Commit 0ca86e9

Browse files
committed
better tests
1 parent 30ef1cd commit 0ca86e9

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

E2eTest/WhereTest.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ public async Task Where1Test()
1313
var page = await this.NewPageAsync();
1414
await page.DeleteDatabaseAsync("Where.Where1");
1515
var result = await this.RunTestPageMethodAsync(p => p.Where1);
16-
Assert.AreEqual("OK", result);
16+
Assert.That.AreJsonEqual("[1,2]", result);
1717
}
1818
}

E2eTestWebApp/TestPages/TestPageBase.razor

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
<input data-testid="method" type="text" @bind-value="@method" />
44
<input data-testid="run" type="button" @onclick="@RunAsync" />
55

6-
<input data-testid="output" type="text" @bind-value="@output" />
7-
<input data-testid="clear" type="button" @onclick="@Clear" />
6+
<textarea data-testid="output">@output</textarea>
7+
<input data-testid="clear" type="button" @onclick="@Clear" />

E2eTestWebApp/TestPages/WhereTestPage.cs

+1-6
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
using Magic.IndexedDb;
22
using Magic.IndexedDb.Helpers;
3-
using Microsoft.AspNetCore.Components.Rendering;
43
using Microsoft.AspNetCore.Components;
5-
using System.Runtime.CompilerServices;
6-
using System.Text.Json.Serialization;
7-
using Magic.IndexedDb.SchemaAnnotations;
84
using System.Text.Json;
9-
using System.Reflection.PortableExecutable;
105

116
namespace E2eTestWebApp.TestPages;
127

@@ -46,7 +41,7 @@ await database.AddAsync<Record, int>(new Record()
4641
Int32Field = 3
4742
});
4843
var result = await database
49-
.Where<Record>(x => x.Int32Field < 2)
44+
.Where<Record>(x => x.Int32Field < 3)
5045
.ToListAsync();
5146
return JsonSerializer.Serialize(result.Select(x => x.Id));
5247
}

Magic.IndexedDb/Factories/MagicDbFactory.cs

+10-1
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,19 @@ public async ValueTask DisposeAsync()
4040
var timeout = new CancellationTokenSource(TimeSpan.FromSeconds(10));
4141
await module.InvokeVoidAsync(IndexedDbFunctions.CLOSE_ALL, timeout.Token);
4242
}
43-
finally
43+
catch
44+
{
45+
// do nothing
46+
}
47+
48+
try
4449
{
4550
await module.DisposeAsync();
4651
}
52+
catch
53+
{
54+
// do nothing
55+
}
4756
}
4857

4958
public async ValueTask<IndexedDbManager> OpenAsync(

0 commit comments

Comments
 (0)