Internal Dexie.JS #39
Closed
magiccodingman
started this conversation in
Ideas
Replies: 1 comment 2 replies
-
Aha? In my recollection, Dexie.js is always included internally. And it is here for now: https://github.com/magiccodingman/Magic.IndexedDb/tree/master/Magic.IndexedDb/wwwroot/dexie |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
A while back a PR that I approved removed the original Dexie.JS that was saved internally within the library and instead replaced with using an https external URL to a more recent version.
I was unsure of that change then and I've mostly come around the corner to not liking the idea. I'd rather the project internally update the JS manually. This removes the dependency of external URL's which makes this library useless if someone doesn't have internet. Additionally external URL's outside of wwwroot don't have as easy of a time to be cached in PWA service workers without custom code. As where if it was internal to wwwroot, a blazor WASM PWA app will cache it by default without additional custom code.
This also resolves potential latency on initial loads, creates better offline capabilities, and removes dependencies on external sites.
I'm all ears if you disagree. But I'm just throwing it out there as something I'll likely change if nobody really opposes the logic.
Beta Was this translation helpful? Give feedback.
All reactions