problems with custom alist entry #432

Seme4eg · 2021-11-03T08:12:30Z

Seme4eg
Nov 3, 2021

config.el:

(after! forge
  (push '("gitlab.mycompany.ru" "gitlab.mycompany.ru/api/v4"
          "gitlab.mycompany.ru" forge-gitlab-repository) forge-alist))

.authinfo.gpg: machine gitlab.mycompany.ru/api/v4 login my.username^forge password TOKEN

.git/config:

...
[gitlab "gitlab.mycompany.ru/api/v4"]
	user = my.username

added repo to database, fetched issues and PRs, looked like everything's fine, but when i tried to review-pull-request it prompted me with Git variable 'github.gitlab.mycompany.ru/api/v4.user' is unset. Set to:

And when I set it (locally) , next thing i get is this

And another weird thing that for some reason isn't working for me - i don't see commits in PR

Answered by tarsius

Nov 3, 2021

Sounds like you need to set the git variable forge.remote, see https://magit.vc/manual/forge/Repository-Detection.html.

View full answer

tarsius · 2021-11-03T14:56:11Z

tarsius
Nov 3, 2021
Maintainer

Sounds like you need to set the git variable forge.remote, see https://magit.vc/manual/forge/Repository-Detection.html.

11 replies

Seme4eg Nov 5, 2021
Author

ok, i did try it with another (my own now) gitHUB repo and yes, got same error. And also weird (or maybe it should be like that) thing - i don't see any 'review pull req' shortcut now in this project after i press '@' prefix key in magit buffer:

I did get everything to work again, but reviewing stuff doesn't work again.

config.el -- machine api.github.com login Seme4eg^forge password TOKEN
.git/config:

[core]
	repositoryformatversion = 0
	filemode = true
	bare = false
	logallrefupdates = true
[remote "origin"]
	url = [email protected]:Seme4eg/.doom.d.git
	fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
	remote = origin
	merge = refs/heads/master
	pushRemote = origin
[github]
	user = Seme4eg
[branch "forge-test"]
	pushRemote = origin

when i call github-review-forge-pr-at-point:

tarsius Nov 5, 2021
Maintainer

when i call github-review-forge-pr-at-point

Please ask the author of github-review for help.

tarsius Nov 5, 2021
Maintainer

Actually this sounds familiar, see #380.

Seme4eg Nov 6, 2021
Author

That did help for my opened github repo, but didn't help for the corporate gitlab one. I did add my.username^github-review entry to .gpg file. Now when trying to call review PR i get this error output:

(fn &rest ARGS2)] github-review-errback nil nil))
Error talking to GitHub: ((error http 404 ((error . 404 Not Found))) ((Server .
nginx) (Date . Sat, 06 Nov 2021 06:53:51 GMT) (Content-Type . application/json)
(Content-Length . 25) (Connection . keep-alive) (Cache-Control . no-cache) (Vary
. Origin) (X-Content-Type-Options . nosniff) (X-Frame-Options . SAMEORIGIN)
(X-Request-Id . 01FKT0CR2772SR8MR77TYWC667) (X-Runtime . 0.016707)) (:error
(error http 404 ((error . 404 Not Found))) :peer (:certificates ((:version 3
:serial-number 29:c7:88:d4:6f:6c:73:c5:42:53:da:2c :issuer C=BE,O=GlobalSign
nv-sa,CN=AlphaSSL CA - SHA256 - G2 :valid-from 2021-08-17 :valid-to 2022-09-18
:subject CN=*.mycompany.ru :public-key-algorithm RSA
:certificate-security-level High :signature-algorithm RSA-SHA256 :public-key-id
sha1:82:1c:fd:be:32:4d:6f:bd:dd:e1:b8:60:07:61:5a:df:db:32:4b:89 :certificate-id
sha1:09:8f:6e:2b:b5:95:c5:ed:03:30:72:20:c8:6e:7f:5a:90:46:3a:bc :pem -----BEGIN
CERTIFICATE----- 
...
-----END CERTIFICATE-----
) (:version 3 :serial-number 04:00:00:00:00:01:44:4e:f0:36:31 :issuer
C=BE,O=GlobalSign nv-sa,OU=Root CA,CN=GlobalSign Root CA :valid-from 2014-02-20
:valid-to 2024-02-20 :subject C=BE,O=GlobalSign nv-sa,CN=AlphaSSL CA - SHA256 -
G2 :public-key-algorithm RSA :certificate-security-level Medium
:signature-algorithm RSA-SHA256 :public-key-id
sha1:ac:c1:aa:cb:6a:74:41:0a:72:9a:b5:e2:3f:8c:b4:61:55:cd:94:fa :certificate-id
sha1:4c:27:43:17:17:56:5a:3a:07:f3:e6:d0:03:2c:42:58:94:9c:f9:ec :pem -----BEGIN
CERTIFICATE----- 
...
-----END CERTIFICATE-----
)) :certificate (:version 3 :serial-number 29:c7:88:d4:6f:6c:73:c5:42:53:da:2c
:issuer C=BE,O=GlobalSign nv-sa,CN=AlphaSSL CA - SHA256 - G2 :valid-from
2021-08-17 :valid-to 2022-09-18 :subject CN=*.mycompany.ru :public-key-algorithm
RSA :certificate-security-level High :signature-algorithm RSA-SHA256
:public-key-id sha1:82:1c:fd:be:32:4d:6f:bd:dd:e1:b8:60:07:61:5a:df:db:32:4b:89
:certificate-id sha1:09:8f:6e:2b:b5:95:c5:ed:03:30:72:20:c8:6e:7f:5a:90:46:3a:bc
:pem -----BEGIN CERTIFICATE----- 
...
-----END CERTIFICATE-----

(fn D V &rest _)] (#s(deferred identity deferred:default-errorback
deferred:default-cancel #s(deferred #[257
\302\303�B\302\242B\240\210\301\302\242GU\203�\0\304\300\305\302\242\237#\210\306\207
[#s(deferred deferred:default-callback deferred:default-errorback
deferred:default-cancel #s(deferred deferred:parallel-alist-to-array
deferred:default-errorback #[257 \301�!\210\302\300!\207 [#9
deferred:default-cancel deferred:cancel] 3 

(fn X)] #s(deferred #[257
\211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207
[((owner . v3) (repo . web-arm) (apihost . gitlab.mycompany.ru/api/v4) (num .
372)) oid target headRef pullRequest repository data github-review-save-diff
a-assoc sha github-review-format-diff] 9 

(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred
deferred:default-callback #[257 \300\301�"\207 [message Got an error from the
GitHub API %S!] 4 

(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil) 2
(nil) 1 deferred:post-task ok nil] 5 

(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred
deferred:default-callback #[257
\302\303�B\302\242B\240\210\302\242G\301U\203�\0\304\300\305\302\242\237#\210\306\207
[#s(deferred deferred:default-callback deferred:default-errorback
deferred:default-cancel #s(deferred deferred:parallel-alist-to-array
deferred:default-errorback #[257 \301�!\210\302\300!\207 [#10
deferred:default-cancel deferred:cancel] 3 

(fn X)] #s(deferred #[257
\211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207
[((owner . v3) (repo . web-arm) (apihost . gitlab.mycompany.ru/api/v4) (num .
372)) oid target headRef pullRequest repository data github-review-save-diff
a-assoc sha github-review-format-diff] 9 

(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred
deferred:default-callback #[257 \300\301�"\207 [message Got an error from the
GitHub API %S!] 4 

(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil) 2
(nil) 1 deferred:post-task ok nil] 5 

(fn E)] deferred:default-cancel nil nil nil) nil nil) nil nil)) apply append] 6 

(fn &rest ARGS2)] github-review-errback nil nil))

tarsius Nov 6, 2021
Maintainer

Looks like github-review does not support gitlab.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

problems with custom alist entry #432

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 1 comment 11 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Uh oh!

problems with custom alist entry #432

Uh oh!

Uh oh!

Seme4eg Nov 3, 2021

Replies: 1 comment · 11 replies

Uh oh!

tarsius Nov 3, 2021 Maintainer

Uh oh!

Uh oh!

Seme4eg Nov 5, 2021 Author

Uh oh!

tarsius Nov 5, 2021 Maintainer

Uh oh!

tarsius Nov 5, 2021 Maintainer

Uh oh!

Seme4eg Nov 6, 2021 Author

Uh oh!

tarsius Nov 6, 2021 Maintainer

Seme4eg
Nov 3, 2021

Replies: 1 comment 11 replies

tarsius
Nov 3, 2021
Maintainer

Seme4eg Nov 5, 2021
Author

tarsius Nov 5, 2021
Maintainer

tarsius Nov 5, 2021
Maintainer

Seme4eg Nov 6, 2021
Author

tarsius Nov 6, 2021
Maintainer