Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerDependency warning on build (Affects dev only) #2863

Open
Gaurav0 opened this issue Nov 12, 2024 · 2 comments
Open

peerDependency warning on build (Affects dev only) #2863

Gaurav0 opened this issue Nov 12, 2024 · 2 comments

Comments

@Gaurav0
Copy link
Contributor

Gaurav0 commented Nov 12, 2024

There is a peerDependency warning while installing this package.

Missing peerDependency webpack@^5.0.0 required by ember-source, ember-auto-import, etc.

As these are not dependencies, this does not affect users of this package.

The easiest way to fix is to add some version of webpack 5.x to devDependencies.

I can open a PR if you'd like.

@BobrImperator
Copy link
Collaborator

It should be harmless as you've said.

ember-simple-auth doesn't rely on webpack so I'd prefer to not introduce any dependencies just to hush the log.
Unless you mean somewhere else? The test-apps do have these dependencies though.

packages/ember-simple-auth
├─┬ @ember/test-helpers 3.3.1
│ └─┬ ember-auto-import 2.10.0
│ ├─┬ babel-loader 8.4.1
│ │ └── ✕ missing peer webpack@>=2
│ ├─┬ css-loader 5.2.7
│ │ └── ✕ missing peer webpack@"^4.27.0 || ^5.0.0"
│ ├─┬ mini-css-extract-plugin 2.9.2
│ │ └── ✕ missing peer webpack@^5.0.0
│ └─┬ style-loader 2.0.0
│ └── ✕ missing peer webpack@"^4.0.0 || ^5.0.0"
└─┬ ember-source 5.12.0
└── ✕ missing peer webpack@"^4.0.0 || ^5.0.0"

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jan 1, 2025

I proposed to add it to devDependencies. This will not introduce a new dependency to upstream users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants