Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error while trying to run tests locally #2864

Open
Gaurav0 opened this issue Nov 12, 2024 · 5 comments
Open

Build error while trying to run tests locally #2864

Gaurav0 opened this issue Nov 12, 2024 · 5 comments

Comments

@Gaurav0
Copy link
Contributor

Gaurav0 commented Nov 12, 2024

Versions:

ember-cli: 5.12.0
node: 20.18.0
pnpm: 9.12.3
os: darwin arm64 (MacOS Sequoia 15.1)

In package test-esa:

[gaurav.munjal@MacBookPro test-esa (gaurav/feat/support_partitioned_cookies)]$ ember test   
Environment: test
⠋ BuildingTorii is installed but not configured in config/environment.js!
cleaning up...
Cleanup error.
⠋ cleaning upCannot read properties of undefined (reading 'cleanup')


Stack Trace and Error Report: /var/folders/5n/x1_c935x0sq7lnqzfpsjkt080000gn/T/error.dump.873624881ff2ed0e4589d628770e0a6b.log
ENOENT: no such file or directory, stat '/Users/gaurav.munjal/dev/work/mainmatter/ember-simple-auth/packages/ember-simple-auth/node_modules/.bin/pnpm'


Stack Trace and Error Report: /var/folders/5n/x1_c935x0sq7lnqzfpsjkt080000gn/T/error.dump.9fa6036dd8b668dd27bb4d3ea3bda321.log
[gaurav.munjal@MacBookPro test-esa (gaurav/feat/support_partitioned_cookies)]$ node -v
v20.18.0
[gaurav.munjal@MacBookPro test-esa (gaurav/feat/support_partitioned_cookies)]$ npm -v
10.8.2
[gaurav.munjal@MacBookPro test-esa (gaurav/feat/support_partitioned_cookies)]$ pnpm -v
9.12.3
[gaurav.munjal@MacBookPro test-esa (gaurav/feat/support_partitioned_cookies)]$ ember -v
ember-cli: 5.12.0
node: 20.18.0
os: darwin arm64

Note that I get the same error running:
pnpm run --filter test-esa test
pnpm run --filter test-esa test:one ember-default

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Nov 12, 2024

It looks like adding

hoist=true
hoist-workspace-packages=true

to .npmrc and rerunning pnpm i solves this problem. Would you like me to open a PR with this change?

@BobrImperator
Copy link
Collaborator

Thanks for vigilance!

We don't want to enable hoisting or any additional configuration.
It seems like the issue might've been a bloated lockfile, usually renovate mitigates the problem but we might've missed a lockfile maintenance PR. Everything should be fine now I think.

I'll close this issue but feel free to re-open if you have this problem again.

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Dec 30, 2024

Still having this issue, but I'm unable to reopen.

@BobrImperator
Copy link
Collaborator

Have you tried on a completely fresh clone?

or

rm -rf node_modules/ pnpm-lock.yaml packages/**/node_modules
pnpm install

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Dec 31, 2024

Not sure, but tried it now. Still occurs.

I don't know if it matters, but I did install pnpm using homebrew, not npm or volta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants