Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animations don't play when Hodgepodge's speedupAnimations is enabled #44

Closed
Tree-er233 opened this issue Jan 17, 2024 · 1 comment
Closed

Animations don't play when Hodgepodge's speedupAnimations is enabled #44

Tree-er233 opened this issue Jan 17, 2024 · 1 comment
Labels
mod incompatibility Issue only happens when certain other mods are present

Comments

@Tree-er233
Copy link

Tree-er233 commented Jan 17, 2024 •
edited
Loading

Possible incompatibility issue with hodgepodge.
The animation of flowing fluids and some blocks doesn't play correctly, when Neodymium 0.2 exists. However, Neodymium 0.1.8.5 does not have this problem.
I have tested on GTNH 2.5.1 (both java8 and java21) and the issue does not appear when hodgepodge is disabled.
The video of my issue :

QQ2024118-55211.mp4
QQ2024118-55422.mp4
@makamys
Copy link
Owner

makamys commented Jan 18, 2024

Looks like it's a regression in 0.2, I can reproduce it with that version but not with 0.1.9. Hodgepodge hooks WorldRenderer#getGLCallListForPass to decide which textures need to be updated, but the GL list logic was disabled in #43, so that's probably why.

You can disable Hodgepodge's speedupAnimations as a workaround until it's fixed.

@makamys makamys changed the title Fluid and some blocks animations don't play correctly Animations don't play when Hodgepodge's speedupAnimations is enabled Jan 18, 2024
@makamys makamys added the mod incompatibility Issue only happens when certain other mods are present label Jan 18, 2024
makamys added a commit that referenced this issue Jan 20, 2024
@makamys
Add JVM flag to keep running render list logic
7da5fb9 
Fixes Hodgepodge incompat (#44), but there's probably a better way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mod incompatibility Issue only happens when certain other mods are present
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@makamys @Tree-er233