Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exits with code 1 even when below (above?) thresholds #69

Open
jgrau opened this issue Aug 18, 2017 · 0 comments
Open

Exits with code 1 even when below (above?) thresholds #69

jgrau opened this issue Aug 18, 2017 · 0 comments

Comments

@jgrau
Copy link

jgrau commented Aug 18, 2017

First of all thanks for making this gem. I love static analysis and I love Sandi Metz :)

I see the following behaviour:

❯ bundle exec sandi_meter -v
Ⓢ ⓐ ⓝ ⓓ ⓘ Ⓜ ⓔ ⓣ ⓔ ⓡ  1.2.0

❯ bundle exec sandi_meter -t '10,10,10,10' -p app -q
1. 98% of classes are under 100 lines.
2. 75% of methods are under 5 lines.
3. 99% of method calls accepted are less than 4 parameters.
4. 100% of controllers have one instance variable per action.

❯ echo $?
1

Shouldn't the exit code be 0 when my app performs better than the thresholds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant