Require version in tools installed by pip #1242
Conversation
There was a problem hiding this comment.
Thanks for adding the versions @sara-rn!! 💐 As noticed by the linter, you have forgotten to update the version in the ipython.vm nuspec. Also, ensure to follow good commit practices such as limiting the subject line to 50 characters and using the body to explain what and why you make the changes. I recommend reading https://cbea.ms/git-commit for more info on best practices to write good commit messages. 😉
sara-rn
force-pushed
the
version_pip_tools
branch
from
27b6ab9 to
0b4e293
Compare
sara-rn
force-pushed
the
version_pip_tools
branch
8 times, most recently
from
dff9f40 to
f9fbebb
Compare
| @@ -2,7 +2,7 @@ | |||
| <package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd"> | |||
| <metadata> | |||
| <id>ipython.vm</id> | |||
| <version>8.27.0.20241001</version> | |||
| <version>8.27.0</version> | |||
There was a problem hiding this comment.
you have decreased the version (by removing the date) causing that our CI is testing the old package version without the version, which now fails as it is required. Ensure you increase the version:
| <version>8.27.0</version> | |
| <version>8.27.0.20250122</version> |
More context:
In autoit-ripper.vm the version has been increased, so the date is not needed.
Note the version in ipython.vm was wrong before as it should have used the 0.0.0.DATE format as we didn't use a version when installing the tool.
There was a problem hiding this comment.
@Ana06 changes have been addressed
Ana06
changed the title
sara-rn
force-pushed
the
version_pip_tools
branch
from
f9fbebb to
7cf3d2c
Compare
Update tools installed with pip to include the version in the install script, required by VM-Install-with-PIP.
sara-rn
force-pushed
the
version_pip_tools
branch
from
7cf3d2c to
7ddd292
Compare
Closes #1240
Change the version parameter to required and change tools installed with PIP to include the version