Updated binwalk from python version to rust version #1414
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@socketz Thank you for this and sorry for the delayed response! It looks like there are just a couple of small conflicts that have occurred since this PR. If you could fix those and squash your commits, I can look into merging this ASAP :) |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates binwalk from a Python-based installation to a standalone Rust binary distribution. The change removes binwalk as a Python module dependency and introduces it as a separate Windows executable package.
- Removes binwalk module from Python 3 libraries package
- Creates a new standalone binwalk.vm package with Windows binary distribution
- Updates package dependencies and descriptions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/libraries.python3.vm/tools/modules.xml | Removes binwalk module from Python libraries list |
| packages/libraries.python3.vm/libraries.python3.vm.nuspec | Updates package description and dependency version |
| packages/binwalk.vm/tools/chocolateyuninstall.ps1 | Adds uninstall script for new binwalk package |
| packages/binwalk.vm/tools/chocolateyinstall.ps1 | Adds install script using third-party Windows binary |
| packages/binwalk.vm/binwalk.vm.nuspec | Creates package specification for standalone binwalk |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
…ackages into update-binwalk-rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Chocolatey package for the
binwalkfirmware analysis tool on Windows, and makes minor updates to the Python libraries metapackage. The main changes are the addition of thebinwalk.vmpackage, including installation and uninstallation scripts, and the removal of the Pythonbinwalkmodule from thelibraries.python3.vmmetapackage.New
binwalk.vmpackage:binwalk.vm.nuspecto define a new Chocolatey package for thebinwalkfirmware analysis tool, with a dependency oncommon.vm.chocolateyinstall.ps1script to installbinwalkusing a third-party pre-built binary, including hash verification and category assignment.chocolateyuninstall.ps1script for clean uninstallation ofbinwalk.Updates to Python libraries metapackage:
libraries.python3.vm.nuspecto bump the version, update the description, and change the dependency version forcommon.vm.binwalkPython module frommodules.xml, sincebinwalkis now provided as a standalone package.