-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 13 issues #43
Comments
The v3.0.0 release supports Angular 13. Can you please provide steps to reproduce the problem? |
### Create a new angular app using ng v13. Here is my ng version output $ ng --version Angular CLI: 13.2.6 Angular: 13.2.7 Package Version@angular-devkit/architect 0.1302.6 ### Creating the app: ### INSTALL angular Material The package @angular/[email protected] will be installed and executed. ### Install the generated angular-crud zip file $ npm i --no-save ~/dev/angular-crud/angular-crud/angular-crud-3.0.0.tgz added 1 package, and audited 928 packages in 2s 104 packages are looking for funding found 0 vulnerabilities removed 1 package, and audited 927 packages in 2s 104 packages are looking for funding found 0 vulnerabilities Now try to build Crud components $ ng g angular-crud:crud-module hotel $ tail -40 /tmp/ng-asDpdD/angular-errors.log |
The problem is that there isn't a step in the tutorial to build the project before you pack it, so the index.ts never gets transpiled into index.js and then when it's packed into the tgz and unpacked into the demo/node_modules it doesn't have the js file and node can't find the module. To fix it, just insert |
You should be able to just install it since it's published on npmjs.org:
|
That works perfectly, but in the README.md file in the root of the repository, the instructions are written with the assumption that we are building from source since the first step is a clone of the repository. Following those instructions precisely does not result in a successful build because the It works in the tests because the tests don't quite follow that process. There is a build that happens in the testing which precedes the |
Can you please create a PR to fix the README? |
When I try to incorporate with angular 13 project I get the following error.
[error] Error: Cannot find module '/home/atlantageek/dev/gis/ui/node_modules/angular-crud/src/crud-module/index'
However, an index.ts file is in the crud-module directory.
The text was updated successfully, but these errors were encountered: