United cores - post fixes (#308)

* Ask for the map instead of asserting on it

GetMap() asserts on a NULL map, so `if (GetMap())` is not a guard against an
object that never reached one -- it is the crash. Add WorldObject::FindMap(),
which returns NULL, and use it in the motion-frame lookup, which is reached from
a destructor after LoadFromDB failed.

Also ApplyNewEvent, which inserts a game_event_status row that a resumed event
already holds: INSERT IGNORE makes it idempotent.

Not compiled.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Send a boarded player the map his ship sails, not the one he stands on

The transfer packet named GetMapId(), which for someone aboard is the vessel's own
map. The client has no terrain for that id -- it was never meant to hear of it --
and dies in CMap::LoadWdt() looking for one. It has to be the map she sails, which
is the map he is leaving and the one his client is still rendering.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Crashes, pets and extractor

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Author: H0zen

src/game/ChatCommands/CreatureCommands.cpp

@@ -1363,7 +1363,7 @@ namespace
                                 cellLoaded ? "yes" : "no",
                                 inWorld ? "" : " (not in world)");
 
-        if (watched->Where().ShareFrame(unit->Where()))
+        if (CanBeSeen(*unit, *watched))
         {
             handler.PSendSysMessage("    distance=%.3f",
                                     watched->Where().DistanceTo(unit->Where()));

src/game/ChatCommands/DebugCommands.cpp

@@ -54,6 +54,11 @@
 #include "ObjectMgr.h"
 #include "ObjectGuid.h"
 #include "SpellMgr.h"
+#include "Pet.h"
+#include "Map.h"
+#include "MapManager.h"
+#include "TransportMap.h"
+#include "Transports.h"
 
 /**
  * @brief Handler for HandleDebugSendSpellFailCommand command.
@@ -1789,4 +1794,102 @@ bool ChatHandler::HandleDebugPhaseCommand(char* args)
 
     m_session->GetPlayer()->HandleEmoteCommand(emote_id);
     return true;
-}
+}
+/**
+ * @brief `.debug minion` -- where a player's minions actually are, deck boundary and all.
+ *
+ * The steady state is what needs reading, not the transition: a pet left on a deck looks
+ * exactly like a pet that followed and stopped, and the difference is a map id. So this
+ * reports three things that must agree and usually do not: what the master OWNS, what stands
+ * on the master's own map, and what stands on every deck sailing that map.
+ */
+bool ChatHandler::HandleDebugMinionCommand(char* /*args*/)
+{
+    Player* master = getSelectedPlayer();
+    if (!master)
+    {
+        master = m_session ? m_session->GetPlayer() : NULL;
+    }
+
+    if (!master)
+    {
+        SendSysMessage(LANG_NO_CHAR_SELECTED);
+        SetSentErrorMessage(true);
+        return false;
+    }
+
+    PSendSysMessage("master   %s", DescribeSpatially(master).c_str());
+    PSendSysMessage("petguid  %s  transport=%s",
+                    master->GetPetGuid().GetString().c_str(),
+                    master->GetTransport() ? "yes" : "no");
+
+    int owned = 0;
+    master->CallForAllControlledUnits(
+        [this, &owned](Unit* minion)
+        {
+            ++owned;
+            PSendSysMessage("owned    %s", DescribeSpatially(minion).c_str());
+        },
+        CONTROLLED_PET | CONTROLLED_MINIPET | CONTROLLED_GUARDIANS | CONTROLLED_TOTEMS |
+        CONTROLLED_CHARM);
+
+    if (!owned)
+    {
+        SendSysMessage("owned    NONE -- the master controls nothing the sweep can find");
+    }
+
+    Map* on = master->FindMap();
+    if (!on)
+    {
+        return true;
+    }
+
+    DumpPetsOn(on, "onmap");
+
+    // The decks are the other half of the answer: a pet the master no longer owns is still
+    // standing somewhere, and it is almost always on the hull he walked off.
+    if (TransportMap* deck = on->AsTransport())
+    {
+        if (Transport* vessel = deck->Vessel())
+        {
+            if (Map* sailed = vessel->GetMap())
+            {
+                DumpPetsOn(sailed, "ashore");
+            }
+        }
+    }
+    else
+    {
+        MapManager::TransportsByMapType::const_iterator vessels =
+            sMapMgr.m_TransportsByMap.find(on->GetId());
+        if (vessels != sMapMgr.m_TransportsByMap.end())
+        {
+            for (Transport* vessel : vessels->second)
+            {
+                if (TransportMap* hull = vessel->AsMap())
+                {
+                    DumpPetsOn(hull, "ondeck");
+                }
+            }
+        }
+    }
+
+    return true;
+}
+
+/// Every pet standing on one map, whoever owns it. `label` says which map it was.
+void ChatHandler::DumpPetsOn(Map* on, char const* label)
+{
+    for (auto const& entry : on->GetObjectsStore().GetElements<Pet>())
+    {
+        Pet* pet = entry.second;
+        if (!pet)
+        {
+            continue;
+        }
+
+        Unit* owner = pet->GetOwner();
+        PSendSysMessage("%-8s %s owner=%s", label, DescribeSpatially(pet).c_str(),
+                        owner ? owner->GetGuidStr().c_str() : "(none)");
+    }
+}

src/game/MotionGenerators/MotionFrame.cpp

@@ -416,9 +416,12 @@ namespace Motion
         // The one place in the server where "which world am I in?" is decided. A boarded
         // unit moves in its vessel's frame; everything else in the map's. Nothing above
         // this call knows the difference, and nothing above it needs to.
-        if (mover.GetMap() && mover.GetMap()->AsTransport())
+        if (Map const* on = mover.FindMap())
         {
-            return s_transportFrame;
+            if (on->AsTransport())
+            {
+                return s_transportFrame;
+            }
         }
 
         return s_worldFrame;

src/game/Object/Camera.cpp

@@ -101,7 +101,7 @@ void Camera::SetView(WorldObject* obj, bool update_far_sight_field /*= true*/)
         return;
     }
 
-    if (!m_owner.Where().ShareFrame(obj->Where()))
+    if (!CanBeSeen(*obj, m_owner))
     {
         sLog.outError("Camera::SetView, viewpoint is not in map with camera's owner");
         return;

src/game/Object/Corpse.cpp

@@ -321,7 +321,7 @@ bool Corpse::LoadFromDB(uint32 lowguid, Field* fields)
  */
 bool Corpse::IsVisibleForInState(Player const* u, WorldObject const* viewPoint, bool inVisibleList) const
 {
-    return IsInWorld() && u->IsInWorld() && InReach(*this, *viewPoint, GetMap()->GetVisibilityDistance() + (inVisibleList ? World::GetVisibleObjectGreyDistance() : 0.0f), false);
+    return IsInWorld() && u->IsInWorld() && SeenWithin(*this, *viewPoint, GetMap()->GetVisibilityDistance() + (inVisibleList ? World::GetVisibleObjectGreyDistance() : 0.0f), false);
 }
 
 /**

src/game/Object/DynamicObject.cpp

@@ -318,7 +318,7 @@ bool DynamicObject::IsVisibleForInState(Player const* u, WorldObject const* view
     }
 
     // normal case
-    return InReach(*this, *viewPoint, GetMap()->GetVisibilityDistance() + (inVisibleList ? World::GetVisibleObjectGreyDistance() : 0.0f), false);
+    return SeenWithin(*this, *viewPoint, GetMap()->GetVisibilityDistance() + (inVisibleList ? World::GetVisibleObjectGreyDistance() : 0.0f), false);
 }
 
 /**

src/game/Object/GameObject.cpp

@@ -679,7 +679,7 @@ bool GameObject::IsVisibleForInState(Player const* u, WorldObject const* viewPoi
     }
 
     // Transport always visible at this step implementation
-    if (IsTransport() && Where().ShareFrame(u->Where()))
+    if (IsTransport() && CanBeSeen(*this, *u))
     {
         return true;
     }
@@ -747,7 +747,7 @@ bool GameObject::IsVisibleForInState(Player const* u, WorldObject const* viewPoi
     }
 
     // check distance
-    return InReach(*this, *viewPoint, GetMap()->GetVisibilityDistance() +
+    return SeenWithin(*this, *viewPoint, GetMap()->GetVisibilityDistance() +
                              (inVisibleList ? World::GetVisibleObjectGreyDistance() : 0.0f), false);
 }
 

src/game/Object/Object.h

@@ -765,6 +765,11 @@ class WorldObject : public Object
 
         void SetMap(Map* map);
         Map* GetMap() const { MANGOS_ASSERT(m_currMap); return m_currMap; }
+
+        /// The map, or NULL, for the paths that legitimately run on an object which never
+        /// reached one -- a destructor after LoadFromDB failed, above all. GetMap() asserts
+        /// there, so `if (GetMap())` is not a guard, it is the crash.
+        Map* FindMap() const { return m_currMap; }
         // used to check all object's GetMap() calls when object is not in world!
         void ResetMap();
 

src/game/Object/Pet.cpp

@@ -27,6 +27,7 @@
 #include <algorithm>
 #include <string>
 #include "Pet.h"
+#include "TransportMap.h"
 #include "Database/DatabaseEnv.h"
 #include "Log.h"
 #include "WorldPacket.h"
@@ -164,8 +165,17 @@ void Pet::Update(uint32 update_diff, uint32 diff)
         {
             // unsummon pet that lost owner
             Unit* owner = GetOwner();
+            // A minion whose master is on ANOTHER MAP is mid-crossing, not off its leash.
+            // Stepping on or off a deck leaves them in different frames for the one tick
+            // before TransportMap's reconciler draws it across, and InReach fails closed on
+            // a cross-frame question. Unsummoning on that answer is how a pet vanished the
+            // instant its master went ashore.
+            const bool crossingDeck = owner && !Where().ShareFrame(owner->Where()) &&
+                                      ((FindMap() && FindMap()->AsTransport()) ||
+                                       (owner->FindMap() && owner->FindMap()->AsTransport()));
+
             if (!owner ||
-                (!InReach(*this, *owner, GetMap()->GetVisibilityDistance()) && (owner->GetCharmGuid() && (owner->GetCharmGuid() != GetObjectGuid()))) ||
+                (!crossingDeck && !InReach(*this, *owner, GetMap()->GetVisibilityDistance()) && (owner->GetCharmGuid() && (owner->GetCharmGuid() != GetObjectGuid()))) ||
                 (isControlled() && !owner->GetPetGuid()))
             {
                 Unsummon(PET_SAVE_REAGENTS);

src/game/Object/Player.cpp

@@ -1904,7 +1904,9 @@ bool Player::TeleportTo(uint32 mapid, float x, float y, float z, float orientati
                 if (m_transport)
                 {
                     data.WriteBit(1);   // has transport
-                    data << uint32(GetMapId());
+                    // The map he is LEAVING, and that is the one the ship sails. Never her
+                    // own: the client has no terrain for it and dies in CMap::LoadWdt().
+                    data << uint32(m_transport->GetMapId());
                     data << uint32(m_transport->GetEntry());
                 }
                 else