Commit fd7759d
committed
[Fix] LFGDungeons.dbc field types and index
LfgDungeonsEntryfmt started with 'i' instead of the index marker 'n',
so DBCFileLoader::GetFormatRecordSize never sets index_pos and the
store is keyed by row instead of by dungeon ID. Row index equals ID
for 0 of 240 records, and 83 IDs are >= 240 and unreachable; every
sLfgDungeonsStore.LookupEntry(id) call returns the wrong record or
NULL.
Separately, mapID was typed float, so DBCFileLoader::getFloat
reinterpret-casts the raw int bytes and map 43 reads back as the
denormal 6.02558e-44; every consumer's (uint32) cast collapses to 0,
sending every LFD teleport to Eastern Kingdoms.
Adopt TC's verified format string "nsiiiiiiiiixxixixiiii", change
mapID to int32 (name kept to avoid touching the 3 consumer casts),
drop the four dead fields (faction, textureFilename, order_index,
description_lang -- zero readers anywhere in tree), and name the
trailing four columns Random_ID/Count_tank/Count_healer/Count_damage
to match server-four's names for the same DBC columns.
Entry() preserved verbatim. Verified all 13 LfgDungeonsEntry consumer
sites across LFGMgr.cpp, LFGMgrProposal.cpp, LFGMgrQueue.cpp reference
only fields retained by this change (ID, minLevel, maxLevel,
expansionLevel, difficulty, typeID, flags, mapID, group_id, Entry()).
MapID == -1 handling (49 rows) is a separate, later concern -- not
addressed here.1 parent 6220de7 commit fd7759d
2 files changed
Lines changed: 7 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1289 | 1289 | | |
1290 | 1290 | | |
1291 | 1291 | | |
1292 | | - | |
| 1292 | + | |
1293 | 1293 | | |
1294 | 1294 | | |
1295 | 1295 | | |
1296 | 1296 | | |
1297 | 1297 | | |
1298 | | - | |
| 1298 | + | |
1299 | 1299 | | |
1300 | 1300 | | |
1301 | 1301 | | |
1302 | | - | |
1303 | | - | |
1304 | 1302 | | |
1305 | | - | |
1306 | 1303 | | |
1307 | | - | |
1308 | | - | |
1309 | | - | |
1310 | | - | |
1311 | | - | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
1312 | 1308 | | |
1313 | 1309 | | |
1314 | 1310 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| |||
0 commit comments