Error: Compiling: quantum/keymap_introspection.c

[10bn]

I tried using Miryoku with the latest QMK branch to enable support for the “Azoteq Touchpad,” but I encountered an error during the build process.

Following the instructions from this discussion, I copied the Miryoku userspace and the 3w6 keyboard folder from the Miryoku_QMK branch to the latest QMK branch.

❯ make 3w6/rev2:manna-harbour_miryoku:flash QMK_USER=users/manna-harbour_miryoku

QMK Firmware 0.27.0
☒ 3w6/rev2: LAYOUT: Layout macro should not be defined within ".h" files.
Making 3w6/rev2 with keymap manna-harbour_miryoku and target flash

☒ 3w6/rev2: LAYOUT: Layout macro should not be defined within ".h" files.
avr-gcc (Homebrew AVR GCC 8.5.0_2) 8.5.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Size before:
   text    data     bss     dec     hex filename
      0   25650       0   25650    6432 3w6_rev2_manna-harbour_miryoku.hex

Generating: .build/obj_3w6_rev2_manna-harbour_miryoku/src/info_config.h                             [WARNINGS]
 | 
 | ☒ 3w6/rev2: LAYOUT: Layout macro should not be defined within ".h" files.
 | 
Generating: .build/obj_3w6_rev2_manna-harbour_miryoku/src/default_keyboard.h                        [WARNINGS]
 | 
 | ☒ 3w6/rev2: LAYOUT: Layout macro should not be defined within ".h" files.
 | 
Generating: .build/obj_3w6_rev2_manna-harbour_miryoku/src/default_keyboard.c                        [WARNINGS]
 | 
 | ☒ 3w6/rev2: LAYOUT: Layout macro should not be defined within ".h" files.
 | 
Compiling: quantum/keymap_introspection.c                                                          In file included from quantum/eeconfig.h:24,
                 from quantum/keycode_config.h:23,
                 from quantum/quantum.h:41,
                 from ./.build/obj_3w6_rev2_manna-harbour_miryoku/src/default_keyboard.h:27,
                 from users/manna-harbour_miryoku/manna-harbour_miryoku.c:6,
                 from quantum/keymap_introspection.c:9:
quantum/keymap_introspection.c: In function 'key_override_count_raw':
quantum/util.h:48:89: error: division 'sizeof (const key_override_t ** {aka const struct key_override_t **}) / sizeof (const key_override_t * {aka const struct key_override_t *})' does not compute the number of array elements [-Werror=sizeof-pointer-div]
 #    define ARRAY_SIZE(array) (__builtin_choose_expr(IS_ARRAY((array)), sizeof((array)) / sizeof((array)[0]), (void)0))
                                                                                         ^
quantum/keymap_introspection.c:153:12: note: in expansion of macro 'ARRAY_SIZE'
     return ARRAY_SIZE(key_overrides);
            ^~~~~~~~~~
In file included from quantum/keymap_introspection.c:9:
users/manna-harbour_miryoku/manna-harbour_miryoku.c:57:24: note: first 'sizeof' operand was declared here
 const key_override_t **key_overrides = (const key_override_t *[]){
                        ^~~~~~~~~~~~~
In file included from quantum/eeconfig.h:24,
                 from quantum/keycode_config.h:23,
                 from quantum/quantum.h:41,
                 from ./.build/obj_3w6_rev2_manna-harbour_miryoku/src/default_keyboard.h:27,
                 from users/manna-harbour_miryoku/manna-harbour_miryoku.c:6,
                 from quantum/keymap_introspection.c:9:
quantum/util.h:48:111: error: void value not ignored as it ought to be
 #    define ARRAY_SIZE(array) (__builtin_choose_expr(IS_ARRAY((array)), sizeof((array)) / sizeof((array)[0]), (void)0))
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
quantum/keymap_introspection.c:153:12: note: in expansion of macro 'ARRAY_SIZE'
     return ARRAY_SIZE(key_overrides);
            ^~~~~~~~~~
quantum/keymap_introspection.c: At top level:
quantum/util.h:48:89: error: division 'sizeof (const key_override_t ** {aka const struct key_override_t **}) / sizeof (const key_override_t * {aka const struct key_override_t *})' does not compute the number of array elements [-Werror=sizeof-pointer-div]
 #    define ARRAY_SIZE(array) (__builtin_choose_expr(IS_ARRAY((array)), sizeof((array)) / sizeof((array)[0]), (void)0))
                                                                                         ^
quantum/keymap_introspection.c:160:16: note: in expansion of macro 'ARRAY_SIZE'
 _Static_assert(ARRAY_SIZE(key_overrides) <= (QK_KB), "Number of key overrides is abnormally high. Are you using SAFE_RANGE in an enum for key overrides?");
                ^~~~~~~~~~
In file included from quantum/keymap_introspection.c:9:
users/manna-harbour_miryoku/manna-harbour_miryoku.c:57:24: note: first 'sizeof' operand was declared here
 const key_override_t **key_overrides = (const key_override_t *[]){
                        ^~~~~~~~~~~~~
In file included from quantum/eeconfig.h:24,
                 from quantum/keycode_config.h:23,
                 from quantum/quantum.h:41,
                 from ./.build/obj_3w6_rev2_manna-harbour_miryoku/src/default_keyboard.h:27,
                 from users/manna-harbour_miryoku/manna-harbour_miryoku.c:6,
                 from quantum/keymap_introspection.c:9:
quantum/util.h:48:111: error: void value not ignored as it ought to be
 #    define ARRAY_SIZE(array) (__builtin_choose_expr(IS_ARRAY((array)), sizeof((array)) / sizeof((array)[0]), (void)0))
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
quantum/keymap_introspection.c:160:16: note: in expansion of macro 'ARRAY_SIZE'
 _Static_assert(ARRAY_SIZE(key_overrides) <= (QK_KB), "Number of key overrides is abnormally high. Are you using SAFE_RANGE in an enum for key overrides?");
                ^~~~~~~~~~
quantum/util.h:48:31: error: expression in static assertion is not an integer
 #    define ARRAY_SIZE(array) (__builtin_choose_expr(IS_ARRAY((array)), sizeof((array)) / sizeof((array)[0]), (void)0))
                               ^
quantum/keymap_introspection.c:160:16: note: in expansion of macro 'ARRAY_SIZE'
 _Static_assert(ARRAY_SIZE(key_overrides) <= (QK_KB), "Number of key overrides is abnormally high. Are you using SAFE_RANGE in an enum for key overrides?");
                ^~~~~~~~~~
quantum/keymap_introspection.c: In function 'key_override_count_raw':
quantum/keymap_introspection.c:154:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1: all warnings being treated as errors
 [ERRORS]
 | 
 | 
 | 
make[1]: *** [.build/obj_3w6_rev2_manna-harbour_miryoku/quantum/keymap_introspection.o] Error 1
Make finished with errors
make: *** [3w6/rev2:manna-harbour_miryoku:flash] Error 1

  ~/code/keyboards/user_keymaps_still/qmk_firmware   playground !11 ?13                                                                                                                      12s  02:58:58 PM
❯ 

[winmillwill]

Looks like you need to apply the fix described here: https://docs.qmk.fm/ChangeLog/20240825#key-override-keymap-c-signature-change-24120

on the line described here:

In file included from quantum/keymap_introspection.c:9:
users/manna-harbour_miryoku/manna-harbour_miryoku.c:57:24: note: first 'sizeof' operand was declared here
 const key_override_t **key_overrides = (const key_override_t *[]){
                        ^~~~~~~~~~~~~

I just figured this out myself and all I can say is it made compilation complete without error, no idea yet whether the resulting firmware works as expected (and I'm new at this so no idea about much of anything really).

[10bn]

Thanks, I'll look into it!

[manna-harbour]

Also see #361.