Skip to content

Setting CarPlayManager.interfaceController.delegate should not change internal CarPlayManager behavior. #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MaximAlien opened this issue Aug 4, 2021 · 1 comment · Fixed by #3219
Closed

Setting CarPlayManager.interfaceController.delegate should not change internal CarPlayManager behavior. #3220

MaximAlien opened this issue Aug 4, 2021 · 1 comment · Fixed by #3219
Assignees
@MaximAlien
Labels
CarPlay Bugs, improvements and feature requests on Apple CarPlay UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.

Comments

@MaximAlien
Copy link
Contributor

Mapbox Navigation SDK version: main

In case if users want to listen to the changes from CPInterfaceController they can set their own delegate object to CarPlayManager.interfaceController.delegate. Since CarPlayManager also internally listens to these changes it'll be overwritten and some internal behavior will break: for example routes, which were requested and shown in preview mode will still be visible after dismissing preview. Example:

Screen Shot 2021-08-03 at 5 10 36 PM
@MaximAlien MaximAlien added UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. CarPlay Bugs, improvements and feature requests on Apple CarPlay labels Aug 4, 2021
@MaximAlien MaximAlien self-assigned this Aug 4, 2021
@MaximAlien
Copy link
Contributor Author

MaximAlien commented Aug 4, 2021 •
edited
Loading

As a possible fix CarPlayManager can provide own set of delegate methods and pass-through some of them via CarPlayManagerDelegate.

@MaximAlien MaximAlien mentioned this issue Aug 4, 2021
Merged
@MaximAlien MaximAlien linked a pull request Aug 20, 2021 that will close this issue
CarPlay refactoring and bugfixing. #3219
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaximAlien MaximAlien

Labels
CarPlay Bugs, improvements and feature requests on Apple CarPlay UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CarPlay refactoring and bugfixing. mapbox/mapbox-navigation-ios
1 participant
@MaximAlien