Skip to content

Commit 6bd19c2

Browse files
committed
Bug 1938060 [wpt PR 49758] - DOM: Move moveBefore() returns undefined, a=testonly
Automatic update from web-platform-tests DOM: Move moveBefore() returns undefined See discussion in whatwg/dom#1335. R=nrosenthalchromium.org Bug: 40150299 Change-Id: I50aeafb913abb4b63480be4532254f367abf37b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097561 Reviewed-by: Noam Rosenthal <nrosenthalchromium.org> Commit-Queue: Dominic Farolino <domchromium.org> Cr-Commit-Position: refs/heads/main{#1397950} -- wpt-commits: 37cad0c49e62655850799c6f6ee165b3ceacebdd wpt-pr: 49758 UltraBlame original commit: 7345177f4c7b0628e97d6fb86c41df63b081bb4a
1 parent 728d3c5 commit 6bd19c2

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

testing/web-platform/tests/dom/nodes/moveBefore/tentative/Node-moveBefore.html

+14-3
Original file line numberDiff line numberDiff line change
@@ -221,11 +221,22 @@
221221
a.append(b);
222222
a.append(c);
223223
assert_array_equals(a.childNodes, [b, c]);
224-
assert_equals(a.moveBefore(b, b), b);
224+
assert_equals(a.moveBefore(c, b), undefined, "moveBefore() returns undefined");
225+
assert_array_equals(a.childNodes, [c, b]);
226+
}, "moveBefore() returns undefined");
227+
228+
test(() => {
229+
const a = document.body.appendChild(document.createElement("div"));
230+
const b = document.createElement("div");
231+
const c = document.createElement("div");
232+
a.append(b);
233+
a.append(c);
234+
assert_array_equals(a.childNodes, [b, c]);
235+
a.moveBefore(b, b);
225236
assert_array_equals(a.childNodes, [b, c]);
226-
assert_equals(a.moveBefore(c, c), c);
237+
a.moveBefore(c, c);
227238
assert_array_equals(a.childNodes, [b, c]);
228-
}, "Inserting a node before itself should not move the node");
239+
}, "Moving a node before itself should not move the node");
229240

230241
test(() => {
231242
const disconnectedOrigin = document.createElement('div');

0 commit comments

Comments
 (0)