Skip to content

Commit 6856c01

Browse files
committed
Bug 1924180 [wpt PR 48581] - Rename & refactor invoker commands to reflect new spec decisions., a=testonly
Automatic update from web-platform-tests Rename & refactor invoker commands to reflect new spec decisions. Invoker commands now live solely on HTMLButtonElement, and have been dropped from HTMLInputElement. This was discussed and resolved + minuted in Jul 18 WHATNOT meeting: whatwg/html#10471 (comment)) Words must be separated with dashes. This was discussed and resolved + minuted in Jul 18 WHATNOT meeting: whatwg/html#10471 (comment)) "Custom" commands now require a double dash (`--`) prefix. This was discussed & resolved + minuted in the Jul 25 OpenUI meeting: openui/open-ui#969 (comment) In addition, CommandEvent#invoker is now renamed to CommandEvent#source as discussed and resolved + minuted in Jul 18 WHATNOT meeting: whatwg/html#10471 (comment)) This CL updates the tests & implementation to follow these changes. The changes can also be found in the spec PR which reflects this updated status: whatwg/html#9841 Bug: 40284894 Change-Id: Iefa91a1736867239a21f8717aee1fcaaa54fdfd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839601 Reviewed-by: Mason Freed <masonfchromium.org> Reviewed-by: Luke <lwarlowigalia.com> Commit-Queue: Keith Cirkel <chromiumkeithcirkel.co.uk> Cr-Commit-Position: refs/heads/main{#1367705} -- wpt-commits: 5df7a2c02bb50efa0368910fd49242c08def7a5d wpt-pr: 48581 UltraBlame original commit: 604a5ed051c0566ff7afefe33c36dfef96d6b950
1 parent 949f684 commit 6856c01

16 files changed

+590
-177
lines changed

testing/web-platform/tests/html/semantics/invokers/interesttarget-on-popover-behavior.tentative.html

+15-5
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,9 @@
698698
interestaction
699699
"
700700
"
701-
togglepopover
701+
toggle
702+
-
703+
popover
702704
"
703705
)
704706
;
@@ -782,7 +784,9 @@
782784
interestaction
783785
"
784786
"
785-
togglepopover
787+
toggle
788+
-
789+
popover
786790
"
787791
)
788792
;
@@ -860,7 +864,9 @@
860864
interestaction
861865
"
862866
"
863-
togglepopover
867+
toggle
868+
-
869+
popover
864870
"
865871
)
866872
;
@@ -944,7 +950,9 @@
944950
interestaction
945951
"
946952
"
947-
togglepopover
953+
toggle
954+
-
955+
popover
948956
"
949957
)
950958
;
@@ -1022,7 +1030,9 @@
10221030
interestaction
10231031
"
10241032
"
1025-
tOgGlEpOpOvEr
1033+
tOgGlE
1034+
-
1035+
pOpOvEr
10261036
"
10271037
)
10281038
;

testing/web-platform/tests/html/semantics/invokers/invokeevent-dispatch-shadow.tentative.html

+20-18
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@
283283
null
284284
;
285285
let
286-
childEventInvoker
286+
childEventSource
287287
=
288288
null
289289
;
@@ -298,7 +298,7 @@
298298
null
299299
;
300300
let
301-
hostEventInvoker
301+
hostEventSource
302302
=
303303
null
304304
;
@@ -325,11 +325,11 @@
325325
.
326326
target
327327
;
328-
childEventInvoker
328+
childEventSource
329329
=
330330
e
331331
.
332-
invoker
332+
source
333333
;
334334
}
335335
{
@@ -362,11 +362,11 @@
362362
.
363363
target
364364
;
365-
hostEventInvoker
365+
hostEventSource
366366
=
367367
e
368368
.
369-
invoker
369+
source
370370
;
371371
}
372372
{
@@ -389,7 +389,7 @@
389389
bubbles
390390
:
391391
true
392-
invoker
392+
source
393393
:
394394
slot
395395
composed
@@ -434,10 +434,10 @@
434434
;
435435
assert_equals
436436
(
437-
childEventInvoker
437+
childEventSource
438438
slot
439439
"
440-
invoker
440+
source
441441
is
442442
child
443443
inside
@@ -476,10 +476,10 @@
476476
;
477477
assert_equals
478478
(
479-
hostEventInvoker
479+
hostEventSource
480480
host
481481
"
482-
invoker
482+
source
483483
is
484484
retargeted
485485
to
@@ -496,7 +496,7 @@
496496
shadow
497497
boundaries
498498
retargeting
499-
invoker
499+
source
500500
"
501501
)
502502
;
@@ -604,6 +604,8 @@
604604
command
605605
=
606606
'
607+
-
608+
-
607609
test
608610
-
609611
command
@@ -620,7 +622,7 @@
620622
null
621623
;
622624
let
623-
eventInvoker
625+
eventSource
624626
=
625627
null
626628
;
@@ -647,11 +649,11 @@
647649
.
648650
target
649651
;
650-
eventInvoker
652+
eventSource
651653
=
652654
e
653655
.
654-
invoker
656+
source
655657
;
656658
}
657659
{
@@ -687,10 +689,10 @@
687689
;
688690
assert_equals
689691
(
690-
eventInvoker
692+
eventSource
691693
host
692694
"
693-
invoker
695+
source
694696
is
695697
host
696698
"
@@ -702,7 +704,7 @@
702704
shadow
703705
CommandEvent
704706
retargets
705-
invoker
707+
source
706708
to
707709
host
708710
element

0 commit comments

Comments
 (0)