Merge branch 'stable-23.10' into MCOL-5758-BLOOM-FILTER-PRE-JOIN-GSOC-2025-REDESIGNED

Author: AestheticAkhmad

.drone.jsonnet

@@ -311,7 +311,8 @@ local Pipeline(branch, platform, event, arch="amd64", server="10.6-enterprise",
       ' --container-name ' + getContainerName("mtr") +
       ' --distro ' + platform +
       ' --suite-list $${MTR_SUITE_LIST}' +
-      ' --triggering-event ' + event,
+      ' --triggering-event ' + event
+      + if std.endsWith(result, 'ASan') then ' --run-as-extern' else '',
     ],
     [if (std.member(ignoreFailureStepList, "mtr")) then "failure"]: "ignore",
 

build/run_mtr.sh

@@ -9,6 +9,7 @@ optparse.define short=c long=container-name desc="Name of the Docker container w
 optparse.define short=d long=distro desc="Linux distro for which mtr is runned" variable=DISTRO
 optparse.define short=s long=suite-list desc="Comma-separated list of test suites to run" variable=MTR_SUITE_LIST
 optparse.define short=e long=triggering-event desc="Event that triggers testrun" variable=EVENT
+optparse.define short=E long=run-as-extern desc="Run MTR with --extern flag" variable=EXTERN default=false value=true
 optparse.define short=D long=download-data desc="Download and extract data from S3 for extended MTR" variable=DOWNLOAD_DATA default=false value=true
 optparse.define short=F long=full-mtr desc="Run Full Mtr" variable=FULL_MTR default=false value=true
 
@@ -20,6 +21,7 @@ fi
 
 if [[ $FULL_MTR = true ]]; then
     DOWNLOAD_DATA=true
+    EXTERN=true
 fi
 
 MTR_FULL_SET="basic,bugfixes,devregression,autopilot,extended,multinode,oracle,1pmonly"
@@ -82,7 +84,7 @@ fi
 
 EXTERN_FLAG=""
 
-if [[ $FULL_MTR = true ]]; then
+if [[ $EXTERN = true ]]; then
     EXTERN_FLAG="--extern socket=${SOCKET_PATH}"
 fi
 

dbcon/mysql/ha_mcs_impl.cpp

@@ -1348,15 +1348,14 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
 
   // Save the item list
   List<Item> items;
-  SELECT_LEX select_lex;
 
   if (ha_mcs_common::isUpdateStatement(thd->lex->sql_command))
   {
     items = (thd->lex->first_select_lex()->item_list);
     thd->lex->first_select_lex()->item_list = thd->lex->value_list;
   }
 
-  select_lex = *lex->first_select_lex();
+  SELECT_LEX* select_lex = lex->first_select_lex();
 
   //@Bug 2808 Error out on order by or limit clause
   //@bug5096. support dml limit.
@@ -1412,7 +1411,7 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
 
     gwi.clauseType = WHERE;
 
-    if (getSelectPlan(gwi, select_lex, updateCP, false, false, false, condStack) !=
+    if (getSelectPlan(gwi, *select_lex, updateCP, false, false, false, condStack) !=
         0)  //@Bug 3030 Modify the error message for unsupported functions
     {
       if (gwi.cs_vtable_is_update_with_derive)

dbcon/mysql/ha_view.h

@@ -54,7 +54,8 @@ class View
   uint32_t processJoin(gp_walk_info& gwi, std::stack<execplan::ParseTree*>&);
 
  private:
-  SELECT_LEX fSelect;
+  // Lifetime of fSelect is managed by MDB and must be longer than View object
+  SELECT_LEX& fSelect;
   gp_walk_info* fParentGwip;
   execplan::CalpontSystemCatalog::TableAliasName fViewName;
 };