FastColoredTextBox: Fix 'n' under mono. #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Fixes' issue #177.
Under mono, the mnemonic assigned to the general tab's new profile button is active even when the script editor has focus, so the 'n' key isn't passed to the editor at all. It doesn't trigger the button either, it seems to just disappear.
More information and several potential solutions are laid out in the issue, but the one implemented in this small patch simply disables the mnemonic on the button if the Script Editor tab is selected, and restores it once it's un-selected.
Tested under Gentoo Linux / Mono 6.12.0.122 and Windows 10, everything seems happy now.
It doesn't actually fix the problem, but it does make things work again.