Backend UI-Websocket: get user.globalRole instead of default guest role on AlertingConfigs (OpenEMS#2409)

* fetch user.globalRole instead of guest on AlertingConfigs

This commit is one of many prepare PRs / commits for a bigger PR:
SumStateAlert OpenEMS#2260
By Seperating the big OpenEMS#2260 into smaller commits we would like to make the review easier.

* handleSet and Get UserAlertingConfigs check for Role Admin or else false

helper Method introduced, that checks if the user for the Edge is an admin.
If that's the case, the user is allowed to set either other user settings or receive other userSettings

* Fixed logic error on userIsAdmin in handle Get and SetUserAlertingConfig

* changed return type from Boolean to boolean on userIsAdmin method

---------

Co-authored-by: Kai Jeschek <[email protected]>
Co-authored-by: Kai Jeschek <[email protected]>

Author: DerStoecki

io.openems.backend.uiwebsocket/src/io/openems/backend/uiwebsocket/impl/OnRequest.java

@@ -495,7 +495,7 @@ private CompletableFuture<GenericJsonrpcResponseSuccess> handleGetSetupProtocolD
 	/**
 	 * Handles a {@link GetUserAlertingConfigsRequest}.
 	 *
-	 * @param user    {@User} who called the request
+	 * @param user    {@link User} who called the request
 	 * @param request the {@link SetUserAlertingConfigsRequest}
 	 * @return the JSON-RPC Success Response Future
 	 * @throws OpenemsException on error
@@ -505,10 +505,10 @@ private CompletableFuture<? extends JsonrpcResponseSuccess> handleGetUserAlertin
 		var edgeId = request.getEdgeId();
 		List<AlertingSetting> users;
 
-		if (user.getRole(edgeId).orElse(Role.GUEST).isLessThan(Role.ADMIN)) {
-			users = List.of(this.parent.metadata.getUserAlertingSettings(edgeId, user.getId()));
-		} else {
+		if (userIsAdmin(user, edgeId)) {
 			users = this.parent.metadata.getUserAlertingSettings(edgeId);
+		} else {
+			users = List.of(this.parent.metadata.getUserAlertingSettings(edgeId, user.getId()));
 		}
 
 		return CompletableFuture.completedFuture(//
@@ -518,7 +518,7 @@ private CompletableFuture<? extends JsonrpcResponseSuccess> handleGetUserAlertin
 	/**
 	 * Handles a {@link SetUserAlertingConfigsRequest}.
 	 *
-	 * @param user    {@User} who called the request
+	 * @param user    {@link User} who called the request
 	 * @param request the {@link SetUserAlertingConfigsRequest}
 	 * @return the JSON-RPC Success Response Future
 	 * @throws OpenemsException      on error
@@ -527,14 +527,13 @@ private CompletableFuture<? extends JsonrpcResponseSuccess> handleGetUserAlertin
 	private CompletableFuture<? extends JsonrpcResponseSuccess> handleSetUserAlertingConfigsRequest(User user,
 			SetUserAlertingConfigsRequest request) throws OpenemsException {
 		var edgeId = request.getEdgeId();
-		var role = user.getRole(edgeId).orElse(Role.GUEST);
 		var userId = user.getId();
 		var userSettings = request.getUserSettings();
 
 		var containsOtherUsersSettings = userSettings.stream() //
 				.anyMatch(u -> !Objects.equals(u.getUserId(), userId));
 
-		if (containsOtherUsersSettings && role.isLessThan(Role.ADMIN)) {
+		if (containsOtherUsersSettings && !userIsAdmin(user, edgeId)) {
 			throw new OpenemsException(
 					"Not allowed to update/set alerting information for other users as user [" + userId + "]");
 		}
@@ -544,6 +543,10 @@ private CompletableFuture<? extends JsonrpcResponseSuccess> handleSetUserAlertin
 		return CompletableFuture.completedFuture(new GenericJsonrpcResponseSuccess(request.getId()));
 	}
 
+	private static boolean userIsAdmin(User user, String edgeId) {
+		return user.getRole(edgeId).map(role -> role.isAtLeast(Role.ADMIN)).orElse(false);
+	}
+
 	/**
 	 * Handles a {@link GetEdgesRequest}.
 	 *
@@ -580,5 +583,4 @@ private CompletableFuture<? extends JsonrpcResponseSuccess> handleGetEdgeRequest
 		return CompletableFuture //
 				.completedFuture(new GetEdgeResponse(request.getId(), edgeMetadata));
 	}
-
 }