fix(pdf): show 'Do you have an attorney?' row in attorney section

When a patient selects 'I do not have an attorney' the attorney section
was entirely hidden, which caused the answer to not appear at all (or
in older code, to overlap with the section title). Now:
- The 'attorney-mva-has-attorney' answer is extracted from the
  QuestionnaireResponse and threaded into AttorneyInfo/AttorneyDataInput
- The section renders when the has-attorney answer is populated,
  even if no attorney details exist
- A proper 'Do you have an attorney? / I do not have an attorney'
  label-value row renders as the first field in the section

Closes OTR-1884.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: saewitz

packages/zambdas/src/shared/pdf/sections/attorneyInfo.ts

@@ -2,9 +2,13 @@ import { ATTORNEY_FIRM_EXTENSION_URL, formatPhoneNumberDisplay } from 'utils';
 import { createConfiguredSection, DataComposer } from '../pdf-common';
 import { AttorneyDataInput, AttorneyInfo, PdfSection } from '../types';
 
-export const composeAttorneyData: DataComposer<AttorneyDataInput, AttorneyInfo> = ({ attorneyRelatedPerson }) => {
+export const composeAttorneyData: DataComposer<AttorneyDataInput, AttorneyInfo> = ({
+  attorneyRelatedPerson,
+  hasAttorneyAnswer,
+}) => {
   if (!attorneyRelatedPerson) {
     return {
+      hasAttorneyAnswer,
       firm: '',
       firstName: '',
       lastName: '',
@@ -29,6 +33,7 @@ export const composeAttorneyData: DataComposer<AttorneyDataInput, AttorneyInfo>
   const fax = getPhoneDisplay('fax');
 
   return {
+    hasAttorneyAnswer,
     firm,
     firstName,
     lastName,
@@ -39,7 +44,7 @@ export const composeAttorneyData: DataComposer<AttorneyDataInput, AttorneyInfo>
 };
 
 const hasAttorneyInfo = (info: AttorneyInfo): boolean =>
-  !!(info.firm || info.firstName || info.lastName || info.email || info.mobile || info.fax);
+  !!(info.hasAttorneyAnswer || info.firm || info.firstName || info.lastName || info.email || info.mobile || info.fax);
 
 export const createAttorneyInfoSection = <TData extends { attorney?: AttorneyInfo }>(): PdfSection<
   TData,
@@ -53,6 +58,18 @@ export const createAttorneyInfoSection = <TData extends { attorney?: AttorneyInf
       // Each row is gated by `shouldShow` (so customer `hiddenFields` overrides
       // are honored) and by truthiness of the value (compact render: empty
       // optional fields are omitted, like the original behavior).
+      if (shouldShow('attorney-mva-has-attorney') && attorneyInfo.hasAttorneyAnswer) {
+        client.drawLabelValueRow(
+          'Do you have an attorney?',
+          attorneyInfo.hasAttorneyAnswer,
+          styles.textStyles.regular,
+          styles.textStyles.regular,
+          {
+            drawDivider: true,
+            dividerMargin: 8,
+          }
+        );
+      }
       if (shouldShow('attorney-mva-firm') && attorneyInfo.firm) {
         client.drawLabelValueRow('Firm', attorneyInfo.firm, styles.textStyles.regular, styles.textStyles.regular, {
           drawDivider: true,

packages/zambdas/src/shared/pdf/types.ts

@@ -737,6 +737,7 @@ export interface OccupationalMedicineEmployerInfo extends PdfData {
 }
 
 export interface AttorneyInfo extends PdfData {
+  hasAttorneyAnswer?: string;
   firm: string;
   firstName: string;
   lastName: string;
@@ -846,6 +847,7 @@ export interface OccupationalMedicineEmployerDataInput {
 
 export interface AttorneyDataInput {
   attorneyRelatedPerson?: RelatedPerson;
+  hasAttorneyAnswer?: string;
 }
 
 export interface PatientPaymentsDataInput {

packages/zambdas/src/shared/pdf/visit-details-pdf.ts

@@ -1,6 +1,7 @@
 import {
   AppointmentContext,
   BUCKET_NAMES,
+  flattenQuestionnaireAnswers,
   getCoding,
   getReasonForVisitAndAdditionalDetailsFromAppointment,
   getReasonForVisitOptionsForServiceCategory,
@@ -112,7 +113,12 @@ const composeVisitDetailsData: DataComposer<VisitDetailsInput, VisitDetailsData>
     consentForms: composeConsentFormsData({ encounter, consents, questionnaireResponse, timezone }),
     documents: composeDocumentsData(documents),
     emergencyContact: composeEmergencyContactData({ emergencyContactResource }),
-    attorney: composeAttorneyData({ attorneyRelatedPerson }),
+    attorney: composeAttorneyData({
+      attorneyRelatedPerson,
+      hasAttorneyAnswer: flattenQuestionnaireAnswers(questionnaireResponse?.item ?? []).find(
+        (item) => item.linkId === 'attorney-mva-has-attorney'
+      )?.answer?.[0]?.valueString,
+    }),
     employer: composeEmployerData({
       employer: employerOrganization,
       workersCompCoverage: coverages.workersComp,