'Solution' #1776
'Solution' #1776
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 Your code meets the task requirements and constraints effectively. The only suggestion is to enhance the __truediv__ method by explicitly raising a ZeroDivisionError when the divisor is zero, which will make your code more robust and user-friendly. Keep up the excellent work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| def __truediv__(self, divisor: Union[int, float]) -> "Distance": | ||
| """Ділить дистанцію на число (округлює до 2 знаків).""" | ||
| if isinstance(divisor, (int, float)) and divisor != 0: |
There was a problem hiding this comment.
The __truediv__ method should handle the case where the divisor is zero more explicitly. Although it returns NotImplemented, it might be better to raise a ZeroDivisionError to clearly indicate the error, as dividing by zero is undefined.
No description provided.