Solution #1779
Solution #1779
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 The functionality is solid and meets the task requirements. There are a few minor improvements you could consider, such as handling division by zero to prevent runtime errors and refining type hints for clarity and consistency. Keep up the excellent work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: "int| float | Distance") -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter should be int | float | Distance instead of the string format. This will ensure proper type checking and is consistent with the rest of the code.
| return Distance(self.km + other.km) | ||
| return Distance(self.km + other) | ||
|
|
||
| def __iadd__(self, other: "int| float | Distance") -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter should be int | float | Distance instead of the string format. This will ensure proper type checking and is consistent with the rest of the code.
| self.km += other | ||
| return self | ||
|
|
||
| def __mul__(self, other: int | float) -> "Distance | None": |
There was a problem hiding this comment.
The return type hint Distance | None is misleading because the method does not return None in any case. Consider removing None from the type hint.
| if isinstance(other, (int, float)): | ||
| return Distance(self.km * other) | ||
|
|
||
| def __truediv__(self, other: int | float) -> "Distance | None": |
There was a problem hiding this comment.
The return type hint Distance | None is misleading because the method does not return None in any case. Consider removing None from the type hint.
| return Distance(self.km * other) | ||
|
|
||
| def __truediv__(self, other: int | float) -> "Distance | None": | ||
| if isinstance(other, (int, float)): |
There was a problem hiding this comment.
Consider adding a check to handle division by zero to prevent runtime errors.
No description provided.