py-distance-class task #1784
py-distance-class task #1784
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 Your code meets the task requirements and constraints, and you've done well to include all the necessary magic methods. While there are a couple of areas for improvement, such as handling division by zero in the __truediv__ method and allowing the __sub__ method to handle subtraction with integers or floats, these are minor issues that don't significantly impact the core functionality. Keep up the good work, and consider these enhancements for future robustness and consistency! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __sub__(self, other: "Distance") -> "Distance": | ||
| if isinstance(other, Distance): | ||
| return Distance(self.km - other.km) | ||
|
|
There was a problem hiding this comment.
The __sub__ method currently only handles subtraction with another Distance object. To maintain consistency with other methods, consider adding support for subtracting an integer or float.
| def __truediv__(self, other: float) -> "Distance": | ||
| if isinstance(other, (int, float)): | ||
| return Distance(round(self.km / other, 2)) |
There was a problem hiding this comment.
The __truediv__ method should handle division by zero to prevent runtime errors. Consider adding a check to raise an exception if other is zero.
No description provided.