Task done #1786
Task done #1786
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 Your code is clean, follows good practices, and meets all the task requirements. The only suggestion is to use Union[Distance, int, float] for type hints to ensure compatibility with older Python versions. Keep up the excellent work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: "Distance | int | float") -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter should be updated to use Union from the typing module for better readability and compatibility with older Python versions. Use Union[Distance, int, float] instead of Distance | int | float.
| return Distance(self.km + other) | ||
| return NotImplemented | ||
|
|
||
| def __iadd__(self, other: "Distance | int | float") -> "Distance": |
There was a problem hiding this comment.
Similar to the __add__ method, the type hint for the other parameter should use Union[Distance, int, float] for consistency and compatibility.
| self.km += other | ||
| return self | ||
|
|
||
| def __mul__(self, factor: "int | float") -> "Distance": |
There was a problem hiding this comment.
The type hint for the factor parameter should use Union[int, float] instead of int | float for better compatibility with older Python versions.
| return Distance(self.km * factor) | ||
| return NotImplemented | ||
|
|
||
| def __truediv__(self, divisor: "int | float") -> "Distance": |
There was a problem hiding this comment.
The type hint for the divisor parameter should use Union[int, float] instead of int | float for better compatibility with older Python versions.
| return Distance(round(self.km / divisor, 2)) | ||
| return NotImplemented | ||
|
|
||
| def __lt__(self, other: "Distance | int | float") -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter should use Union[Distance, int, float] instead of Distance | int | float for consistency and compatibility.
| return self.km < other | ||
| return NotImplemented | ||
|
|
||
| def __gt__(self, other: "Distance | int | float") -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter should use Union[Distance, int, float] instead of Distance | int | float for consistency and compatibility.
| return self.km > other | ||
| return NotImplemented | ||
|
|
||
| def __eq__(self, other: "Distance | int | float") -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter should use Union[Distance, int, float] instead of Distance | int | float for consistency and compatibility.
| return self.km == other | ||
| return NotImplemented | ||
|
|
||
| def __le__(self, other: "Distance | int | float") -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter should use Union[Distance, int, float] instead of Distance | int | float for consistency and compatibility.
| return self.km <= other | ||
| return NotImplemented | ||
|
|
||
| def __ge__(self, other: "Distance | int | float") -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter should use Union[Distance, int, float] instead of Distance | int | float for consistency and compatibility.
No description provided.