-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1793
base: master
Are you sure you want to change the base?
Solution #1793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the Distance
class! 🎉 Your code meets the task requirements and constraints, and you've done well with the magic methods and type annotations. While there are minor improvements suggested, such as ensuring the __init__
, __mul__
, and __truediv__
methods handle float
types for better precision, these don't impact the core functionality. Keep up the good work and consider these enhancements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
class Distance: | ||
# Write your code here | ||
pass | ||
def __init__(self, km: int) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The __init__
method should accept km
as a float
instead of int
to handle decimal values for kilometers, as per the task requirements.
self.km += other | ||
return self | ||
|
||
def __mul__(self, factor: int) -> "Distance": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The __mul__
method should accept factor
as a float
instead of int
to handle multiplication with decimal values, as per the task requirements.
return Distance(self.km * factor) | ||
return NotImplemented | ||
|
||
def __truediv__(self, divisor: int) -> "Distance": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The __truediv__
method should accept divisor
as a float
instead of int
to handle division with decimal values, as per the task requirements.
No description provided.