'Solution' #1794
Open
'Solution' #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliasymak24
suggested changes
Feb 26, 2025
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: Distance | int) -> Distance: |
There was a problem hiding this comment.
What if other is float here? check everywhere
app/main.py
Outdated
Comment on lines
50
to
58
| def __le__(self, other: Distance | int) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km <= other.km | ||
| return self.km <= other | ||
|
|
||
| def __ge__(self, other: Distance | int) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km >= other.km | ||
| return self.km >= other |
There was a problem hiding this comment.
try to rewrite these two methods in one line each. Use previously created magic methods
Hint: <= is the same as not >
oliasymak24
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.