Develop #31
Develop #31
Conversation
There was a problem hiding this comment.
Great job on implementing the core functionality for managing movies in your application! 🎉 Your code meets the task requirements and constraints, and the endpoints are well-structured. While there are a few areas for improvement, such as handling optional fields more explicitly and ensuring method validity, these are minor and do not critically impact the functionality. Keep up the good work, and consider the feedback for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/routes/movies.py
Outdated
| db.refresh(language) | ||
| languages.append(language) | ||
|
|
||
| new_movie_data = movie.model_dump(exclude={"country", "genres", "actors", "languages"}) |
There was a problem hiding this comment.
Ensure that model_dump is a valid method for your MovieCreate schema. If this method does not exist, it will raise an AttributeError.
| class Config: | ||
| from_attributes = True |
There was a problem hiding this comment.
The from_attributes configuration is not a standard Pydantic configuration option. If you intended to use a feature like ORM mode, consider using orm_mode = True instead.
|
|
No description provided.