Implement CRUD for Movies

[zazmarga]

No description provided.

[mateacademy-ai-mentor]

---

Thank you for your hard work on this pull request! While your implementation for the movie deletion and update endpoints is mostly on point, there are a few critical issues that need to be addressed before we can proceed:

1. Incorrect Import Statement: The import statement for ceil is incorrect. Please ensure it reads from math import ceil.

2. Pagination Logic: There are several issues with pagination logic:

   • The condition if end >= items: should be if end > items: to correctly determine if there are more pages.
   • The calculation of total_pages should use ceil(len(data) / per_page) to ensure the total number of pages is rounded up correctly.
   • The condition if not items or page > total_pages: might not work as expected. Consider checking if page is greater than total_pages separately.

3. Error Handling in update_movie:

   • Catching ValueError might not be appropriate. Consider using a more specific exception like SQLAlchemyError.
   • Setting existing_movie.detail is likely incorrect as MovieModel probably doesn't have a detail attribute.

4. Pydantic Validators:

   • Replace @field_validator with @validator in your Pydantic schemas.
   • The default value for date in MovieUpdateSchema should be None instead of date.

These changes are crucial to ensure the functionality works as intended and aligns with best practices. Once these are addressed, your code will be in great shape! Keep up the great work and don't hesitate to reach out if you need any help. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

[mateacademy-ai-mentor]

Great effort on your Pull Request! 🎉 While the decision is to APPROVE to help you move forward with your learning, there are several important issues that need your attention:

1. Import Statement for ceil: Ensure the import statement is from math import ceil to avoid syntax errors.

2. Pagination Logic:

   • Adjust the condition to if end > items: for correct page determination.
   • Use ceil(len(data) / per_page) for calculating total_pages to ensure proper rounding.
   • Re-evaluate the condition if not items or page > total_pages: to ensure it functions as expected.

3. Error Handling in update_movie:

   • Replace ValueError with a more specific exception like SQLAlchemyError for better error handling.
   • Verify that you are updating the correct attributes of MovieModel, as existing_movie.detail might not exist.

4. Pydantic Validators:

   • Replace @field_validator with @validator in your Pydantic schemas.
   • Ensure optional fields, like date in MovieUpdateSchema, default to None.

These changes are crucial for the functionality and best practices of your code. Address these issues to enhance your solution and learn from this experience. Keep up the good work and continue improving! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

[mateacademy-ai-mentor]

The import statement for ceil is incorrect. It should be from math import ceil instead of from math import ceil /.

[mateacademy-ai-mentor]

Catching ValueError might not be appropriate here. Consider using a more specific exception like SQLAlchemyError for database operations.

[mateacademy-ai-mentor]

Setting existing_movie.detail is likely incorrect as MovieModel probably doesn't have a detail attribute. Ensure that you are updating the correct attributes of the MovieModel.

[mateacademy-ai-mentor]

Replace @field_validator with @validator in your Pydantic schemas. field_validator is not a valid decorator in Pydantic.

[mateacademy-ai-mentor]

The default value for date in MovieUpdateSchema should be None instead of date. Ensure that optional fields are correctly handled.