Solution #44
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| from typing import List | ||
|
|
||
| from fastapi import HTTPException | ||
| from sqlalchemy.exc import SQLAlchemyError | ||
| from sqlalchemy.orm import Session | ||
|
|
||
| from database.models import ( | ||
| MovieModel, | ||
| CountryModel, | ||
| GenreModel, | ||
| ActorModel, | ||
| LanguageModel, | ||
| ) | ||
|
|
||
| from schemas.movies import MovieCreateSchema, MovieUpdateSchema | ||
|
|
||
|
|
||
| def get_movies(db: Session, offset, per_page): | ||
| return ( | ||
| db.query(MovieModel) | ||
| .order_by(MovieModel.id.desc()) | ||
| .offset(offset) | ||
| .limit(per_page) | ||
| .all() | ||
| ) | ||
|
|
||
|
|
||
| def get_movie(db: Session, movie_id): | ||
| return db.query(MovieModel).filter(MovieModel.id == movie_id).first() | ||
|
|
||
|
|
||
| def create_objects(data: List[str], model, db: Session): | ||
| objects = [model(name=element) for element in data] | ||
| db.add_all(objects) | ||
| db.commit() | ||
|
|
||
| for obj in objects: | ||
| db.refresh(obj) | ||
|
|
||
| return objects | ||
|
|
||
|
|
||
| def create_movie(db: Session, movie: MovieCreateSchema): | ||
| try: | ||
|
|
||
| country_data = ( | ||
| db.query(CountryModel).filter(CountryModel.code == movie.country).first() | ||
| ) | ||
| if not country_data: | ||
| country_data = CountryModel(code=movie.country) | ||
| db.add(country_data) | ||
| db.commit() | ||
| db.refresh(country_data) | ||
|
|
||
| genres_data = ( | ||
| db.query(GenreModel).filter(GenreModel.name.in_(movie.genres)).all() | ||
| ) | ||
| if not genres_data: | ||
| genres_data = create_objects(movie.genres, GenreModel, db) | ||
|
Comment on lines
+58
to
+59
There was a problem hiding this comment. The current logic for handling genres, actors, and languages may lead to data integrity issues. If any of these entities partially exist, the |
||
|
|
||
| actors_data = ( | ||
| db.query(ActorModel).filter(ActorModel.name.in_(movie.actors)).all() | ||
| ) | ||
| if not actors_data: | ||
| actors_data = create_objects(movie.actors, ActorModel, db) | ||
|
Comment on lines
+64
to
+65
There was a problem hiding this comment. Similar to the genres handling, the logic for actors may lead to duplicates if some actors already exist. Ensure that only missing actors are created. |
||
|
|
||
| languages_data = ( | ||
| db.query(LanguageModel) | ||
| .filter(LanguageModel.name.in_(movie.languages)) | ||
| .all() | ||
| ) | ||
| if not languages_data: | ||
| languages_data = create_objects(movie.languages, LanguageModel, db) | ||
|
Comment on lines
+72
to
+73
There was a problem hiding this comment. The logic for handling languages can also lead to duplicates if some languages already exist. Modify the logic to create only the missing languages. |
||
|
|
||
| db_movie = MovieModel( | ||
| name=movie.name, | ||
| date=movie.date, | ||
| score=movie.score, | ||
| overview=movie.overview, | ||
| status=movie.status, | ||
| budget=movie.budget, | ||
| revenue=movie.revenue, | ||
| country=country_data, | ||
| genres=genres_data, | ||
| actors=actors_data, | ||
| languages=languages_data, | ||
| ) | ||
|
|
||
| db.add(db_movie) | ||
| db.commit() | ||
| db.refresh(db_movie) | ||
| return db_movie | ||
|
|
||
| except SQLAlchemyError: | ||
| db.rollback() | ||
| raise HTTPException(status_code=400, detail="Invalid input data.") | ||
|
Comment on lines
+94
to
+96
There was a problem hiding this comment. Consider logging the exception details for better debugging and error tracking, rather than just raising a generic HTTPException. There was a problem hiding this comment. Consider adding logging for the SQLAlchemyError to improve error tracking and debugging. |
||
|
|
||
|
|
||
| def delete_movie(db: Session, movie_id: int): | ||
| db_movie = db.query(MovieModel).filter(MovieModel.id == movie_id).first() | ||
| if not db_movie: | ||
| raise HTTPException( | ||
| status_code=404, detail="Movie with the given ID was not found." | ||
| ) | ||
| db.delete(db_movie) | ||
| db.commit() | ||
|
|
||
|
|
||
| def update_movie(db: Session, movie_id: int, movie: MovieUpdateSchema): | ||
| db_movie = db.query(MovieModel).filter(MovieModel.id == movie_id).first() | ||
| if not db_movie: | ||
| raise HTTPException( | ||
| status_code=404, detail="Movie with the given ID was not found." | ||
| ) | ||
|
|
||
| for key, value in movie.dict(exclude_unset=True).items(): | ||
| setattr(db_movie, key, value) | ||
|
|
||
| db.commit() | ||
| db.refresh(db_movie) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error in the path construction for
PATH_TO_MOVIES_CSV. The path should not end with a slash, as it is not a directory. Ensure the path is correctly constructed to point to theimdb_movies.csvfile.