Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solution #45

wants to merge 1 commit into from

Conversation

comnotaDidi
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements effectively! 🎉 The code is well-structured and meets the core requirements, including the necessary endpoints and schema validations. Just a small suggestion: in the patch_movie function, consider returning a success message or the updated movie object instead of raising an HTTPException with a 200 status code. Keep up the good work and happy coding! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +77 to +78
update_movie(db, movie_id, movie)
return HTTPException(status_code=200, detail="Movie updated successfully.")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the patch_movie function, you should return a success message or the updated movie object instead of raising an HTTPException with a 200 status code. Use return {"detail": "Movie updated successfully."} instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants