Solution #46
Solution #46
Conversation
There was a problem hiding this comment.
Great job on implementing the movie management endpoints! 🎉 The core functionality is solid, and you've met the task requirements well. There are a couple of areas for improvement: ensure the update_movie function validates score, budget, and revenue fields, and adjust the pagination logic to handle edge cases correctly. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| db: Session = Depends(get_db) | ||
| ): | ||
| total_items = db.query(MovieModel).count() | ||
| total_pages = total_items // per_page + 1 |
There was a problem hiding this comment.
The calculation of total_pages should be adjusted to correctly handle cases where total_items is a multiple of per_page. Consider using math.ceil(total_items / per_page) to ensure the correct number of pages is calculated.
|
|
||
| @router.patch("/movies/{movie_id}/") | ||
| def update_movie(movie_id: int, movie_data: MovieUpdateSchema, db: Session = Depends(get_db)): | ||
| movie = db.query(MovieModel).filter_by(id=movie_id).first() |
There was a problem hiding this comment.
The update_movie function should validate the score, budget, and revenue fields to ensure they meet the constraints specified in the task description. The score should be between 0 and 100, and budget and revenue should be non-negative.
No description provided.