Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Solution #6

wants to merge 5 commits into from

Conversation

MrEgorLite
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Movie Theater API project! 🎉 The code is well-structured and meets the task requirements effectively. While there are a couple of minor issues, such as a typo in the update_movie function and an incorrect model being used, these do not significantly impact the overall functionality. Keep up the good work, and consider addressing these minor issues to enhance your code further. Happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


if movie.languages:
languages = []
for language in movie.language:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo here. It should be for language in movie.languages: instead of for language in movie.language: to match the plural form used elsewhere.

.first()
)
if not movie_language:
db.add(ActorModel(name=language))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect model used. You are adding ActorModel instead of LanguageModel. This should be corrected to db.add(LanguageModel(name=language)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants