-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #6
base: main
Are you sure you want to change the base?
Solution #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the Movie Theater API project! 🎉 The code is well-structured and meets the task requirements effectively. While there are a couple of minor issues, such as a typo in the update_movie
function and an incorrect model being used, these do not significantly impact the overall functionality. Keep up the good work, and consider addressing these minor issues to enhance your code further. Happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
||
if movie.languages: | ||
languages = [] | ||
for language in movie.language: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo here. It should be for language in movie.languages:
instead of for language in movie.language:
to match the plural form used elsewhere.
.first() | ||
) | ||
if not movie_language: | ||
db.add(ActorModel(name=language)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect model used. You are adding ActorModel
instead of LanguageModel
. This should be corrected to db.add(LanguageModel(name=language))
.
No description provided.