chore: Bump Node and Sass versions, and some misc housekeeping (#7402)

Author: aomarks

.github/workflows/release-canary.yml

@@ -28,7 +28,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v1
         with:
-          node-version: 10
+          node-version: 14
           registry-url: https://registry.npmjs.org/
       - name: Cache dependencies
         uses: actions/cache@v2

.github/workflows/release-nightly.yml

@@ -20,7 +20,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v1
         with:
-          node-version: 10
+          node-version: 14
           registry-url: https://registry.npmjs.org/
       - name: Cache dependencies
         uses: actions/cache@v2

.github/workflows/release-pull-request.yml

@@ -29,7 +29,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v1
         with:
-          node-version: 10
+          node-version: 14
           registry-url: https://registry.npmjs.org/
       - name: Cache dependencies
         uses: actions/cache@v2

.github/workflows/release.yml

@@ -28,7 +28,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v1
         with:
-          node-version: 10
+          node-version: 14
           registry-url: https://registry.npmjs.org/
       - name: Cache dependencies
         uses: actions/cache@v2

.github/workflows/test.yml

@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 10
+          node-version: 14
       - uses: actions/cache@v2
         with:
           path: ~/.npm
@@ -44,7 +44,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 10
+          node-version: 14
       - uses: actions/cache@v2
         with:
           path: |
@@ -64,7 +64,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 10
+          node-version: 14
       - uses: actions/cache@v2
         with:
           path: |
@@ -96,7 +96,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 10
+          node-version: 14
       - uses: actions/cache@v2
         with:
           path: |
@@ -115,7 +115,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 10
+          node-version: 14
       - uses: actions/cache@v2
         with:
           path: |

.stylelintrc.yaml

@@ -42,7 +42,11 @@ rules:
     - true
     - ignorePseudoElements:
         ng-deep
-  scss/at-rule-no-unknown: true
+  scss/at-rule-no-unknown:
+    - true
+    - ignoreAtRules:
+      - provide
+      - require
   # No config allows this:
   #
   # ```scss

package-lock.json

@@ -58,7 +58,6 @@
     "eslint": "^5.1.0",
     "eslint-config-google": "^0.11.0",
     "eslint-plugin-mocha": "^5.0.0",
-    "fibers": "^4.0.2",
     "fs-extra": "^7.0.0",
     "fs-readdir-recursive": "^1.1.0",
     "glob": "^7.1.6",
@@ -83,7 +82,7 @@
     "prettier": "^2.2.1",
     "recast": "^0.17.3",
     "resolve": "^1.3.2",
-    "sass": "^1.34.1",
+    "sass": "^1.41.1",
     "sass-loader": "^7.1.0",
     "semver": "^5.3.0",
     "stylelint": "^13.8.0",

package.json

@@ -862,7 +862,7 @@
   .mdc-dialog__title {
     @include theme.property(
       margin-left,
-      calc(title - 2 * close),
+      'calc(title - 2 * close)',
       $replace: (title: $title-side-padding, close: $close-icon-padding)
     );
   }

packages/mdc-dialog/_mixins.scss

@@ -13,18 +13,21 @@ function main() {
   removeDirectory('.rewrite-tmp');
   removeFilesOfType('css');
   removeFilesOfType('js');
-  removeFilesOfType('d.ts');
+  removeFilesOfType('d.ts', [
+    // This file is hand-written.
+    'packages/mdc-base/externs.d.ts',
+  ]);
   removeFilesOfType('map');
 }
 
 function removeDirectory(directory) {
   del.sync([directory]);
 }
 
-function removeFilesOfType(type) {
+function removeFilesOfType(type, extraIgnore = []) {
   const fileGlob = `packages/**/*.${type}`;
   const filePaths = globSync(fileGlob, {
-    ignore: ['**/node_modules/**'],
+    ignore: ['**/node_modules/**', ...extraIgnore],
   });
   filePaths.forEach((filePath) => {
     fs.unlink(filePath, (err) => {

scripts/build/clean.js

@@ -220,7 +220,6 @@ class CssBundleFactory {
           sourceMap: true,
           includePaths: [getAbsolutePath('/packages/material-components-web/node_modules')],
           implementation: require('sass'),
-          fiber: require('fibers'),
         },
       },
     ];

scripts/webpack/css-bundle-factory.js

@@ -157,7 +157,7 @@ class JsBundleFactory {
         filenamePattern: this.env_.isProd() ? 'material-components-web.min.js' : 'material-components-web.js',
         moduleName: {
           amd: 'material-components-web',
-          root: ['mdc']
+          root: ['mdc'],
         },
       },
       plugins,
@@ -230,7 +230,7 @@ class JsBundleFactory {
  * @param {string} dashedName A dash-separated package name. E.g., "mdc-linear-progress".
  * @return {string} dashedName converted to camelCase. E.g., "mdcLinearProgress".
  */
- function toCamelCase(dashedName) {
+function toCamelCase(dashedName) {
   return dashedName.replace(/-([a-z])/g, (_, letter) => letter.toUpperCase());
 }