-
Notifications
You must be signed in to change notification settings - Fork 178
Open
Labels
bugSomething isn't workingSomething isn't workinglibrary: c++quick(Label used internally)(Label used internally)
Description
When I compiled the library, I got a few Error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax in MSVC.
For example in hct_solver.cc
, there is (Vec3){r, g, b};
. This can be replaced by using standard C++11 aggregate initialization: Vec3{r, g, b};
.
I have also noticed the use absl/container/flat_hash_map.h
in wsmeans.cc
and absl/strings/str_cat.h
in utils.cc
for only a few lines of code. They are easily replaced by std utilities, but understandable for a google project to use abseil.
rakibdev and Edwinfitz
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinglibrary: c++quick(Label used internally)(Label used internally)