Fix ollamaChat.models for non-homogeneous responses

Author: hjh320

ollamaChat.m

@@ -300,7 +300,7 @@
         end
     end
 
-    methods(Static)
+    methods (Static)
         function mdls = models
             %ollamaChat.models - return models available on Ollama server
             %   MDLS = ollamaChat.models returns a string vector MDLS
@@ -312,7 +312,17 @@
             %   "phi".
             endpoint = "http://localhost:11434/api/tags";
             response = webread(endpoint);
-            mdls = string({response.models.name}).';
+            mdls = ollamaChat.extractModelNames(response.models);
+        end
+    end
+
+    methods (Static, Access=?tollamaChat)
+        function mdls = extractModelNames(models)
+            if isstruct(models)
+                mdls = string({models.name}).';
+            else
+                mdls = cellfun(@(md)string(md.name), models);
+            end
             baseMdls = unique(extractBefore(mdls,":latest"));
             % remove all those "mistral:latest", iff those are the only
             % model entries pointing at some model

tests/tollamaChat.m

@@ -9,6 +9,7 @@
         InvalidValuesSetters = iGetInvalidValuesSetters;
         ValidValuesSetters = iGetValidValuesSetters;
         StringInputs = struct('string',{"hi"},'char',{'hi'},'cellstr',{{'hi'}});
+        ModelDataFromTagsResponse = iGetModelDataFromTagsResponse
     end
 
     properties
@@ -396,6 +397,11 @@ function queryModels(testCase)
             testCase.verifyThat(models, ...
                 matlab.unittest.constraints.IsSupersetOf("mistral-nemo"));
         end
+
+        function extractModelNamesFromTagsResponse(testCase, ModelDataFromTagsResponse)
+            mdlNames = ollamaChat.extractModelNames(ModelDataFromTagsResponse);
+            testCase.verifyEqual(mdlNames, ["model1"; "model1:latest"; "model1:old"; "model2"]);
+        end
     end
 
     methods
@@ -609,3 +615,26 @@ function queryModels(testCase)
             "Error","MATLAB:validators:mustBePositive"));
 end
 
+function modelData = iGetModelDataFromTagsResponse
+    modelData = struct();
+    modelData.HomogeneousModelData = [ ...
+            struct( ...
+                "name", "model1:old", ...
+                "size", 123); ...
+            struct( ...
+                "name", "model1:latest", ...
+                "size", 456); ...
+            struct( ...
+                "name", "model2:latest", ...
+                "size", 789)];
+    modelData.NonHomogeneousModelData = { ...
+            struct( ...
+                "name", "model1:old", ...
+                "someName", 123); ...
+            struct( ...
+                "name", "model1:latest", ...
+                "someOtherName", 456); ...
+            struct( ...
+                "name", "model2:latest", ...
+                "yetAnotherName", 789)};
+end