Fix top menu item spacing to match left menu#24507
Open
mellonis wants to merge 1 commit into
Open
Conversation
Top-bar items had `padding: 4px` on labels (and `padding: 8px` on
icons), giving them a cramped feel inconsistent with the rest of the
chrome. The left menu's `.item` uses `padding: 8px 12px`; match that
rhythm so the active/hover pill (rendered via `&::after { inset: 0 }`)
grows to a comfortable size on both axes.
Fixes matomo-org#24463
Contributor
|
Hi @mellonis Cheers |
Contributor
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
Bot
added
the
Stale
github-actions
Bot
removed
the
Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
padding: 4px, which made the active/hover pill too tight (see screenshots in the issue)..navbar-labeland.navbar-icontopadding: 8px 12px, matching the left menu's.itemrule in the same file.&::after { inset: 0 }, so it follows the padded box and now produces the comfortable pill shown in the "what should happen" screenshot.Fixes #24463
Test plan