Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tag configuration duplicated in many places #185

Open
clokep opened this issue Aug 4, 2021 · 4 comments
Open

Build tag configuration duplicated in many places #185

clokep opened this issue Aug 4, 2021 · 4 comments

Comments

@clokep
Copy link
Member

clokep commented Aug 4, 2021

Currently the build tags get duplicated in a handful of places:

Note that the build tags are homeserver specific (and might vary based on the version of the homeserver).

It would be great if complement was able to know which build tags to use somehow by inspecting a file or the homeserver capabilities. This would help avoid the various configs above getting out of sync.

Additionally we should probably:

  • Remove the buildkite CI for complement.
  • Remove the unused pipeline for Synapse.
@clokep
Copy link
Member Author

clokep commented Aug 4, 2021

Remove the unused pipeline for Synapse.

See matrix-org/pipelines#170.

@kegsay
Copy link
Member

kegsay commented Aug 11, 2021

You've done a lot of work on this from what I can see - at what point would you say that this issue is complete?

@clokep
Copy link
Member Author

clokep commented Aug 11, 2021

You've done a lot of work on this from what I can see - at what point would you say that this issue is complete?

I think the main pain point still exists -- you need to specify the attributes in CI for both Synapse, Complement and locally for the complement.sh script. So this is no-where near done.

@kegsay
Copy link
Member

kegsay commented Sep 20, 2022

What is the state of this @clokep over a year later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants