-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nicknames with slashes appear as "undefined" (RELAYMSG) #1411
Comments
Also possibly related: #712 |
I found out that {
"content": {
"body": "\u0001ACTION nominates matrix-appservice-irc the biggest headache since Charybdis#255\u0001",
"msgtype": "m.text"
},
"origin_server_ts": 1626610714905,
"sender": "@irc_undefined:liberta.casa",
"type": "m.room.message",
"unsigned": {
"age": 5619
},
"event_id": "$FCKonM2YAMuLG3vVgxB6zwpH0zkxMkZKPW3XTpRWGuY",
"room_id": "!BOgGhzZDPlkGSgoSdO:liberta.casa"
} I don't know if it's a separate issue or just strongly related to this one. |
@Half-Shot could you acknowledge this issue too and give it label IRCv3? Ref: ircv3/ircv3-specifications#417 RELAYMSG is also currently the most 👍'd issue on Solanum which is what Libera.Chat uses, solanum-ircd/solanum#159. |
We've not actively prioritised IRCv3 features in favour of trying to support existing features / performance improvements, and would probably wish for the community to look at implementing those. Sorry, the resources just aren't enough where we can look at these right now. |
It's not actually an IRCv3 problem, it's because of matrix-org/node-irc#81. However, dendrite actually enforces the allowed mxid characters so it will be unhappy (#1432), but maybe that's a problem for later, since dendrite is already unhappy with a lot of things the bridge does. |
Since this is still not fixed upstream... am I correct that it might be possible to work-around this issue by using a different RELAYMSG seperator than "/"? Has anyone tried some working ones that are unlikely to be used by regular nicknames? Edit: Confirmed, if I use a IRC nickname legal seperator like | it starts working. Not ideal of course, but a work-around. |
Describe the bug
RELAYMSG or nicknames with slashes appear as "undefined" (
@irc_undefined:liberta.casa
) on Matrix.To Reproduce
relaymsg
privilege) on IRC, send one by yourself through/quote RELAYMSG #channel fake/relaymsg :message here
Expected behavior
"message here" appears to be sent by nickname "fake/relaymsg", but instead appears from user "undefined"
Screenshots
IRC:
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: