Skip to content

RTCEncryptionManager: Joiner key rotation grace period #4911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 18, 2025
Merged

RTCEncryptionManager: Joiner key rotation grace period #4911

merged 14 commits into from
Jul 18, 2025

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jul 8, 2025 •
edited
Loading

Fixes https://github.com/element-hq/voip-internal/issues/371

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@BillCarsonFr BillCarsonFr force-pushed the valere/rtc/encryption_mgr/rotate_joiner_with_grace branch from cd3bde8 to 1e5efc3 Compare July 8, 2025 14:52
@BillCarsonFr BillCarsonFr added the T-Task Tasks for the team like planning label Jul 8, 2025
@BillCarsonFr BillCarsonFr marked this pull request as ready for review July 8, 2025 15:22
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner July 8, 2025 15:22
@BillCarsonFr BillCarsonFr requested review from hughns and toger5 July 8, 2025 15:22
@BillCarsonFr BillCarsonFr force-pushed the valere/rtc/encryption_mgr/rotate_joiner_with_grace branch from 1e5efc3 to 1d798cb Compare July 8, 2025 15:24
toger5
toger5 requested changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@toger5 toger5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks very simple (In terms of: done in a way that is easy to follow along) and sane. I do have questions on the tests. So I need a bit of help (with comments) to understand what is supposed to happen.

@BillCarsonFr BillCarsonFr requested a review from toger5 July 18, 2025 08:09
@BillCarsonFr BillCarsonFr added this pull request to the merge queue Jul 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2025
@BillCarsonFr BillCarsonFr added this pull request to the merge queue Jul 18, 2025
Merged via the queue into develop with commit 1fcbc6e Jul 18, 2025
32 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/rtc/encryption_mgr/rotate_joiner_with_grace branch July 18, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toger5 toger5 toger5 approved these changes

@hughns hughns Awaiting requested review from hughns hughns is a code owner automatically assigned from matrix-org/element-call-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillCarsonFr @toger5