Allow building snapshots with the default relase_sdk flow

Author: jmartinesp

.github/workflows/snapshot.yml

@@ -1,5 +1,5 @@
 object BuildVersionsSDK {
-	const val majorVersion = 25
-	const val minorVersion = 4
-	const val patchVersion = 22
+	const val majorVersion = "25"
+	const val minorVersion = "4"
+	const val patchVersion = "22"
 }

buildSrc/src/main/kotlin/BuildVersionsSDK.kt

@@ -32,9 +32,9 @@ def read_version_numbers_from_kotlin_file(file_path):
     with open(file_path, "r") as file:
         content = file.read()
 
-    major_version = int(re.search(r"majorVersion\s*=\s*(\d+)", content).group(1))
-    minor_version = int(re.search(r"minorVersion\s*=\s*(\d+)", content).group(1))
-    patch_version = int(re.search(r"patchVersion\s*=\s*(\d+)", content).group(1))
+    major_version = re.search(r'majorVersion\s*=\s*"(.+)"', content).group(1)
+    minor_version = re.search(r'minorVersion\s*=\s*"(.+)"', content).group(1)
+    patch_version = re.search(r'patchVersion\s*=\s*"(.+)"', content).group(1)
 
     return major_version, minor_version, patch_version
 
@@ -110,7 +110,10 @@ def execute_build_script(script_directory: str, sdk_path: str, module: Module, t
 
 build_version_file_path = get_build_version_file_path(args.module, project_root)
 major, minor, patch = read_version_numbers_from_kotlin_file(build_version_file_path)
-if is_provided_version_higher(major, minor, patch, args.version):
+
+if 'SNAPSHOT' in args.version:
+    print(f"Version {args.version} is a SNAPSHOT version, skipping version check")
+elif is_provided_version_higher(major, minor, patch, args.version):
     print(
         f"The provided version ({args.version}) is higher than the previous version ({major}.{minor}.{patch}) so we can start the release process")
 else:

scripts/build-rust-for-target.py

@@ -25,11 +25,11 @@ def override_version_in_build_version_file(file_path: str, new_version: str):
     with open(file_path, 'r') as file:
         content = file.read()
 
-    new_major, new_minor, new_patch = map(int, new_version.split('.'))
+    new_major, new_minor, new_patch = new_version.split('.')
 
-    content = re.sub(r"(majorVersion\s*=\s*)(\d+)", rf"\g<1>{new_major}", content)
-    content = re.sub(r"(minorVersion\s*=\s*)(\d+)", rf"\g<1>{new_minor}", content)
-    content = re.sub(r"(patchVersion\s*=\s*)(\d+)", rf"\g<1>{new_patch}", content)
+    content = re.sub(r'(majorVersion\s*=\s*)"(.+)"', rf'\g<1>"{new_major}"', content)
+    content = re.sub(r'(minorVersion\s*=\s*)"(.+)"', rf'\g<1>"{new_minor}"', content)
+    content = re.sub(r'(patchVersion\s*=\s*)"(.+)"', rf'\g<1>"{new_patch}"', content)
 
     with open(file_path, 'w') as file:
         file.write(content)
@@ -214,24 +214,25 @@ def main(args: argparse.Namespace):
         get_publish_task(args.module),
     )
 
-    # Success, commit and push changes, then create github release
-    commit_message = f"Bump {args.module.name} version to {args.version} (matrix-rust-sdk to {args.linkable_ref})"
-    print(f"Commit message: {commit_message}")
-    commit_and_push_changes(project_root, commit_message)
-
-    release_name = f"{args.module.name.lower()}-v{args.version}"
-    release_notes = f"https://github.com/matrix-org/matrix-rust-sdk/tree/{args.linkable_ref}"
-    asset_path = get_asset_path(project_root, args.module)
-    asset_name = get_asset_name(args.module)
-    create_github_release(
-        github_token,
-        "https://api.github.com/repos/matrix-org/matrix-rust-components-kotlin",
-        release_name,
-        release_name,
-        release_notes,
-        asset_path,
-        asset_name,
-    )
+    if not 'SNAPSHOT' in args.version:
+        # Success, commit and push changes, then create github release
+        commit_message = f"Bump {args.module.name} version to {args.version} (matrix-rust-sdk to {args.linkable_ref})"
+        print(f"Commit message: {commit_message}")
+        commit_and_push_changes(project_root, commit_message)
+
+        release_name = f"{args.module.name.lower()}-v{args.version}"
+        release_notes = f"https://github.com/matrix-org/matrix-rust-sdk/tree/{args.linkable_ref}"
+        asset_path = get_asset_path(project_root, args.module)
+        asset_name = get_asset_name(args.module)
+        create_github_release(
+            github_token,
+            "https://api.github.com/repos/matrix-org/matrix-rust-components-kotlin",
+            release_name,
+            release_name,
+            release_notes,
+            asset_path,
+            asset_name,
+        )
 
 
 parser = argparse.ArgumentParser()