Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve traversal #5

Open
matteocontrini opened this issue Mar 16, 2021 · 0 comments
Open

Improve traversal #5

matteocontrini opened this issue Mar 16, 2021 · 0 comments

Comments

@matteocontrini
Copy link
Owner

After #3 was merged, some issues were introduced:

  • empty bullet points are rendered in lists
  • empty headings are rendered
  • headings "symbols" (+++ or ---) now have a fixed length instead of depending on the heading length

A possible solution is to restore the previous nested traversal with multiple levels of HtmlTraversal instances, and then passing around a LinksTracker object to gather information about links that should be rendered only at the end of the top-level traversal instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant