Skip to content

Document removal of deprecated DateTime dialog fields (MM-68396) - #1519

Open
sbishel wants to merge 4 commits into
masterfrom
MM-68396-remove-deprecated-fields
Open

Document removal of deprecated DateTime dialog fields (MM-68396)#1519
sbishel wants to merge 4 commits into
masterfrom
MM-68396-remove-deprecated-fields

Conversation

@sbishel

@sbishel sbishel commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Removes the deprecated min_date/max_date (top-level on date elements), min_date/max_date/time_interval (top-level on datetime elements), and datetime_config.allow_manual_time_entry rows from the Interactive Dialog docs, since these fields have been removed server-side in server version 12.0.
  • Adds a "DateTime field breaking change (server version 12.0)" callout in the datetime_config object section explaining that these values must now be sent under datetime_config (using manual_time_entry instead of allow_manual_time_entry), and that un-migrated payloads will have them silently ignored.

Related

  • mattermost/mattermost#MM-68396 — server/webapp removal of the same deprecated fields

Ticket Link

Fixes: https://mattermost.atlassian.net/browse/MM-68396

@github-actions

Copy link
Copy Markdown

Newest code from mattermost has been published to preview environment for Git SHA 2548a30

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2fa594f2-b03c-4b86-80c9-c8acb57b2d34

📥 Commits

Reviewing files that changed from the base of the PR and between 2548a30 and 8fa697f.

📒 Files selected for processing (1)
  • site/content/integrate/plugins/interactive-dialogs/_index.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • site/content/integrate/plugins/interactive-dialogs/_index.md

📝 Walkthrough

Walkthrough

Updates interactive dialog documentation to remove deprecated top-level date and datetime fields, direct integrations to nested datetime_config, and document server version 12.0 breaking changes.

Changes

Interactive dialog configuration

Layer / File(s) Summary
Document nested datetime configuration
site/content/integrate/plugins/interactive-dialogs/_index.md
Removes deprecated top-level fields from the date and datetime tables. Documents their removal or replacement under datetime_config for server version 12.0.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Mergeability Score: ⚪ Minimal · up to 8fa69

This documentation-only PR updates deprecated DateTime field guidance; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the removal of deprecated DateTime dialog fields, which is the main change in the pull request.
Description check ✅ Passed The description accurately explains the deprecated field removals and the new server version 12.0 documentation guidance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MM-68396-remove-deprecated-fields

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@site/content/integrate/plugins/interactive-dialogs/_index.md`:
- Around line 581-583: Update the breaking-change note so `time_interval` is
described as a removed top-level field only for `datetime` elements, while
keeping `min_date` and `max_date` scoped to both `date` and `datetime` elements.
Preserve the existing guidance to send `time_interval` under `datetime_config`
and rename `allow_manual_time_entry` to `manual_time_entry`.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fde28efa-de62-4645-b157-18d4b053ff1d

📥 Commits

Reviewing files that changed from the base of the PR and between 9755670 and 2548a30.

📒 Files selected for processing (1)
  • site/content/integrate/plugins/interactive-dialogs/_index.md

Comment thread site/content/integrate/plugins/interactive-dialogs/_index.md
@sbishel
sbishel requested a review from hanzei July 30, 2026 22:59
@sbishel sbishel added the Do Not Merge Should not be merged until this label is removed label Jul 30, 2026
@github-actions

Copy link
Copy Markdown

Newest code from mattermost has been published to preview environment for Git SHA 41d4de2

@hanzei hanzei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread site/content/integrate/plugins/interactive-dialogs/_index.md Outdated
@github-actions

Copy link
Copy Markdown

Newest code from mattermost has been published to preview environment for Git SHA 157ed00

@github-actions

Copy link
Copy Markdown

Newest code from mattermost has been published to preview environment for Git SHA 8fa697f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge Should not be merged until this label is removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants