Fixing linter and applying PR feedback

Author: avasconcelos114

server/subscribe.go

@@ -41,7 +41,7 @@ const (
 	CommentVisibility          = "commentVisibility"
 	TeamFilter                 = "teamField"
 	CommentVisibilityGroupType = "group"
-	maxDMGMChannelMembers = 200
+	maxDMGMChannelMembers      = 200
 )
 
 type FieldFilter struct {

server/subscribe_test.go

@@ -1807,6 +1807,7 @@ func TestRemoveSubscriptionsForChannelIndexDrift(t *testing.T) {
 
 	err = p.removeSubscriptionsForChannel(testInstance1.GetID(), dmChannelID)
 	assert.NoError(t, err)
+	api.AssertExpectations(t)
 }
 
 func TestRemoveSubscriptionsForChannel(t *testing.T) {
@@ -2001,6 +2002,8 @@ func TestCleanupDMSubscriptionsOnDisconnect(t *testing.T) {
 		}), mock.AnythingOfType("model.PluginKVSetOptions")).Return(true, nil)
 
 		p.cleanupDMSubscriptionsOnDisconnect(testInstance1.GetID(), mattermostUserID)
+
+		api.AssertExpectations(t)
 	})
 
 	t.Run("keeps GM subscription when another member is still connected", func(t *testing.T) {

server/webhook_worker_test.go

@@ -93,6 +93,7 @@ func TestWebhookWorkerDeliveryGuard(t *testing.T) {
 		require.NoError(t, err)
 
 		api.AssertNotCalled(t, "CreatePost", mock.Anything)
+		api.AssertExpectations(t)
 	})
 
 	t.Run("delivers to DM when a member is still connected", func(t *testing.T) {